Skip to content

Commit

Permalink
Add very minimal support for Notifications Beta (#81)
Browse files Browse the repository at this point in the history
fregante authored Mar 27, 2020
1 parent 3079797 commit 2ab32c8
Showing 2 changed files with 37 additions and 6 deletions.
13 changes: 8 additions & 5 deletions extension/index.js
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ class Notifications {

async getList() {
if (!this.list) {
this.list = select.all('.notifications-list .boxed-group', await this.dom);
this.list = select.all('.notifications-list .boxed-group, .js-active-navigation-container', await this.dom);

// Change tooltip direction
for (const group of this.list) {
@@ -45,7 +45,10 @@ function isOpen(el) {

async function updateUnreadCount() {
const latestStatusEl = select('.notification-indicator .mail-status', await notifications.dom);
const latestCount = select('.notification-center .selected .count', await notifications.dom).textContent;
const latestCount = select([
'.notification-center .selected .count', // Classic
'.js-notification-inboxes .selected .count' // Beta
], await notifications.dom).textContent;
const rghCount = getRefinedGitHubUnreadCount();

for (const statusEl of select.all('.notification-indicator .mail-status')) {
@@ -66,10 +69,10 @@ function createNotificationsDropdown() {
const dropdown = domify(`
<details class="NPG-container details-overlay details-reset">
<summary>
<div class="NPG-opener js-menu-target"></div>
</summary>
<div class="NPG-opener js-menu-target"></div>
</summary>
<details-menu class="NPG-dropdown dropdown-menu dropdown-menu-sw notifications-list ${participating} type-${options.dropdown}">
</details-menu>
</details-menu>
</details>
`);
indicator.parentElement.classList.add('position-relative');
30 changes: 29 additions & 1 deletion extension/style.css
Original file line number Diff line number Diff line change
@@ -99,6 +99,34 @@

/* Hide extra content */
.NPG-dropdown.type-compact .age,
.NPG-dropdown.type-compact .AvatarStack {
.NPG-dropdown.type-compact .AvatarStack,
.NPG-dropdown.type-compact .flex-md-row-reverse { /* Beta */
display: none !important;
}

/**
* Beta
*/
:root:root .NPG-dropdown.type-compact .js-active-navigation-container {
width: max-content;
}

.NPG-dropdown .notifications-list-item {
display: flex !important;
align-items: center !important;
justify-content: space-between;
}

.NPG-dropdown .d-flex.flex-column.flex-sm-row.flex-self-start.flex-items-center {
/* Unread indicator and checkbox */
display: none !important;
}

.NPG-dropdown .js-notification-action:not(.notification-action-mark-archived) {
display: none !important;
}

.NPG-dropdown .notification-list-item-actions {
display: block !important;
position: relative !important;
}

0 comments on commit 2ab32c8

Please sign in to comment.