Refactor use generic AccountId type #137

magecnion · 2023-08-29T07:05:45Z

The main purpose of this task is to replace the specific type H160, previously used in the pallet to store asset ownership addresses. To achieve this, two traits have been introduced into the runtime:

AccountMapping: Manages the conversion between AccountId and H160, primarily for use within the precompiles module.
AssetIdToAddress: Returns the initial owner corresponding to the asset_id.

…nto feature/precompile_erc_721

…piles

…721_transfer_from

… refactor/use_generic_accountid

ghost

It looks great in general

ghost · 2023-08-30T08:14:03Z

runtime/src/tests.rs

+	assert_ne!(asset1, asset2);
+
+	// check asset in decimal format
+	assert_eq!(


I don't think this is necessary. it tests the functionality of U256 which is outside of our crate.

I would leave because it is useful when you test through remix as you need number in decimal format

this is not addressed from last review

this is not addressed from last review

I suggest to leave this assert because it's useful when testing remix

pallets/living-assets-ownership/src/lib.rs

pallets/living-assets-ownership/src/traits.rs

runtime/src/lib.rs

… refactor/use_generic_accountid

ghost

lgtm now

pallets/living-assets-ownership/Cargo.toml

pallets/living-assets-ownership/src/lib.rs

asiniscalchi added 30 commits August 1, 2023 11:11

create mock and testing

8a0bc02

first test

0fe9a63

testing ethereum reserved addresses

7ebabef

refactoring

e964668

refactoring

aba874e

refactoring tests

80dd172

fmt

9604f6c

erc721 starting point

390359b

Merge branch 'dev' into feature/precompile_erc_721

64c449a

fmt

5dafd9f

Merge branch 'dev' into feature/precompile_erc_721

e92faae

Merge branch 'feature/solidity_create_collection_return_an_address' i…

21d6842

…nto feature/precompile_erc_721

compiling

e06adce

check selectors

3869690

create trait Erc721

d514f88

Erc721Precompile

2efff92

set mocks

0357938

first implermentation

cec3cbf

first integration of erc721 in the runtime

b0c10ce

fmt

1420c21

check on the collection id

d0c4ce7

test on extract owner form asset_id

aa84dde

Merge branch 'dev' into feature/precompile_erc_721

7e49dae

fix tests

0ec72a7

test for erc721 trait

9be1a5b

Merge branch 'feature/precompile_erc_721' into feature/testing_precom…

2427e0d

…piles

fix compilation

4625aad

refactoring

d858bf0

returning address

6c65ddd

return value is correctly encoded as a n Address

1c9e12a

magecnion added 13 commits August 24, 2023 16:46

Merge branch 'magecnion_change_requests' into feature/precompile_erc_…

3874112

…721_transfer_from

change requests

191bd15

change requests

736aa55

change requests

dbb52e7

change requests

b7d8992

add AccountMapping impl to pallet config

b380cf9

add initial_owner fn to AssetId

e3d23c4

AccountMapping only have AccountId as generic

bdefb24

AccountMapping runtime test

0fd1b46

add AssetIdToAddress impl

eb40e79

Merge branch 'dev' of github.com:freeverseio/laos-ownership-node into…

77d572b

… refactor/use_generic_accountid

fix test after merge

51f5d42

fix test after merge and docs

eb026ae

magecnion marked this pull request as ready for review August 29, 2023 08:12

magecnion requested review from asiniscalchi and a user August 29, 2023 08:12

magecnion linked an issue Aug 29, 2023 that may be closed by this pull request

ERC721.transferFrom #90

Closed

Merge branch 'dev' of github.com:freeverseio/laos-ownership-node into…

a585737

… refactor/use_generic_accountid

ghost reviewed Aug 30, 2023

View reviewed changes

magecnion added 5 commits August 30, 2023 15:59

use Convert substrate trait

2c5d2c2

use Convert substrate trait when parsing from address to account id

6465469

fmt

8bc3826

fix

5d2d74d

Merge branch 'dev' of github.com:freeverseio/laos-ownership-node into…

3a28060

… refactor/use_generic_accountid

ghost approved these changes Aug 31, 2023

View reviewed changes

pallets/living-assets-ownership/Cargo.toml Show resolved Hide resolved

pallets/living-assets-ownership/src/lib.rs Outdated Show resolved Hide resolved

magecnion added 3 commits August 31, 2023 10:15

fmt

2b1242a

change requests

dc8cc56

fmt

1d8c2b9

magecnion merged commit 38d40fa into dev Aug 31, 2023

magecnion deleted the refactor/use_generic_accountid branch August 31, 2023 08:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor use generic AccountId type #137

Refactor use generic AccountId type #137

magecnion commented Aug 29, 2023 •

edited

Loading

ghost left a comment •

edited by ghost

Loading

ghost Aug 30, 2023

magecnion Aug 30, 2023

ghost Aug 31, 2023

magecnion Aug 31, 2023

ghost left a comment

Refactor use generic AccountId type #137

Refactor use generic AccountId type #137

Conversation

magecnion commented Aug 29, 2023 • edited Loading

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

ghost Aug 30, 2023

Choose a reason for hiding this comment

magecnion Aug 30, 2023

Choose a reason for hiding this comment

ghost Aug 31, 2023

Choose a reason for hiding this comment

magecnion Aug 31, 2023

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

magecnion commented Aug 29, 2023 •

edited

Loading

ghost left a comment •

edited by ghost

Loading