This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
removed errors per trait #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiniscalchi
merged commit ed52b66
into
feature/precompile_erc_721_token_uri
4 checks passed
asiniscalchi
added a commit
that referenced
this pull request
Aug 18, 2023
* create mock and testing * first test * testing ethereum reserved addresses * refactoring * refactoring * refactoring tests * fmt * erc721 starting point * fmt * compiling * check selectors * create trait Erc721 * Erc721Precompile * set mocks * first implermentation * first integration of erc721 in the runtime * fmt * check on the collection id * test on extract owner form asset_id * fix tests * test for erc721 trait * fix compilation * refactoring * returning address * return value is correctly encoded as a n Address * is_erc721_contract is not member of PrecompoileSet * test on precompiled contracts * erc721 returns hardcoded address * refactoring * testing return of asset ownership * fix errors * remove unused use * create collection got an uri * refactoring * rewriting testing mod * refactoring * moving check for cllection address in pallet * collection address prefix changed * test passing * test passing * refactoring tests * do not panic the runtime * fmt * solidity tokenId -> _tokenId * erc721 functions are views * update docs * sp-core in std , removed duplicate function * documentaetion * using compilator type ifer * compiler infer the size of the array * added to std feature * rename variable * trait documentation * using pallet errors * Erc721Error created * Erc721Error fix compilation * tests green * revise docuemntation * fmt * better name of constant * create collection has param uri * remove unused error * using sp-std * using sp-std * created CollectionBaseURI * created CollectionBaseURI * BaseURILimit is defined * insering the base uri * insering the base uri * base_uri is set in storage * create_collection trait has base_uri as param * living_assets_ownership pallet tests are green * tests passing * test on base_uri too long * removing use * use Vec * testing minimum arguments * create_collection has a BondedVec tokenURI * removed unued error * fix compilation * refactoring * refactoring * removed legacy doc * BaseURILimit type is not public * traits have Error assiciated tyope * more generiuc signature * fix compilation * test moved where concreate impl is tested * removed harcoded buffer from tests * refactoring * checking for BaseURI bounds * CollectionManager has associated type AssetId * removed errors per trait (#128) * removed errors per trait * removed unused error variant * added doc for error * trait has BaseURI associated type * fix compoilation * BaseURILimit is int pallet::Config trait * fix compoilation * documentation for the value of BaseURILimit * Base_URI is couled to trai Config * usi max length to 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.