-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fun input with ownership #22
Conversation
@gkorland Very thanks. But there are compile errors in the |
merged manually but not mark as merged. |
@freestrings sorry I was off for a week, I'm not sure I follow, do you need me to reopen this PR? |
@freestrings please check my last commit, I think this is the right way to add a way to let the user remove and not only replace with Null on delete |
@gkorland please check
since the function parameter type and return type have changed, I believe it seems better to release it in version 0.3.x that i am planning around mid next month. |
…one (remove the value and not replace with Null)
c712212
to
63b9f81
Compare
@freestrings done |
Fix #8 allows return None on replace --> remove path --> delete the key |
@gkorland Thanks. |
@freestrings It says
|
@gkorland |
@freestrings is it working now? |
@gkorland No. It seems better to merge it manually and close this PR. what do you think? |
@freestrings go for it, it does seem like we're wasting time on git tricks... |
@gkorland this PR merged manually. |
When a value is passed by value and not reference the user can return the original value and avoid clone()