Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting issue in the editor #4354

Closed
LK-ML opened this issue Nov 17, 2024 · 8 comments
Closed

Formatting issue in the editor #4354

LK-ML opened this issue Nov 17, 2024 · 8 comments

Comments

@LK-ML
Copy link

LK-ML commented Nov 17, 2024

Hi there,

first of all: thank you for Freescout! :)
We face an issue with the official saved response module.
When writing a reply, then using a saved response, it sometimes will be enclosed into a " " .
This leads to the formatting being off.

I have previously removed all styles from the saved responses, however the span is still being added sometimes. I am trying to replicate the issue.

Anwendungs-Version | 1.8.157
PHP 8.3.6
Are you using CloudFlare: No
Are you using non-official modules: No

@freescout-help
Copy link
Collaborator

Can you share some screenshots and HTML of the saved reply?
Can you reproduce the issue on demo.freescout.net?

@LK-ML
Copy link
Author

LK-ML commented Nov 17, 2024

Yes, the issue can be reproduced in demo.freescout.net:

  1. I removed the tag from the saved reply "General Answer" in the demo. I saved that and confirmed the new version has no span.

no span

  1. Then I answered an existing ticket, wrote a few words, then used the Saved Reply "General Answer" The saved reply is added correctly without the span at first.

no span in ticket
no span

Removing the line break before the Saved Reply text moves the Saved Reply to the end of the previous text.

hi-edited

The span-tag is added automatically after this removal:

after editing

@freescout-help
Copy link
Collaborator

It's still difficult to figure out what exactly you are doing.

@LK-ML
Copy link
Author

LK-ML commented Nov 17, 2024

Sorry for that - let me try again :).

To replicate the issue in the demo:

  1. Create a new ticket. Write "hello world".

  2. Use a Saved Reply, which has no styles applied - like "General Answer". Its applied correctly. Check in the code view - no span-tag.

  3. Click before the first letter of the saved reply. In the Demo, this is before H of "Hi". Press backspace to delete the break before the H. Open code view - the "Hi" gets enclosed in a span with a font size 13.4px.

  4. Open Saved Replies. Edit "General Answer". Open Code View - no span-Tag in the Saved Reply.

This is not an issue in demo. When using saved replies to have common answers, the saved reply will end up with font size 13.4px, while the rest is a different font size. The mail looks bad :).

Is this a bit more helpful?

@freescout-help
Copy link
Collaborator

The text looks fine even with the span tag added:

1 (2)

The code:

1 (1)

@freescout-help freescout-help changed the title Formatting issue in Saved Response Module Formatting issue in the editor Nov 17, 2024
@freescout-help
Copy link
Collaborator

@freescout-help
Copy link
Collaborator

Fixed in the master branch and will be published in the next release.

@LK-ML
Copy link
Author

LK-ML commented Nov 18, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants