Fix an issue when a module could not be updated due to existing Publi…

…c symlink - closes #2709
freescout-help-desk · Feb 16, 2023 · 9dfad3b · 9dfad3b
1 parent 4eadecc
commit 9dfad3b
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/app/Http/Controllers/ModulesController.php b/app/Http/Controllers/ModulesController.php
@@ -511,6 +511,18 @@ public function ajax(Request $request)
                         } else {
                             // Extract
                             try {
+                                // Sometimes by some reason Public folder becomes a symlink leading to itself.
+                                // It causes an error during updating process.
+                                // https://github.com/freescout-helpdesk/freescout/issues/2709
+                                $public_folder = $module->getPath().DIRECTORY_SEPARATOR.'Public';
+                                try {
+                                    if (is_link($public_folder)) {
+                                        unlink($public_folder);
+                                    }
+                                } catch (\Exception $e) {
+                                    // Do nothing.
+                                }
+
                                 \Helper::unzip($module_archive, \Module::getPath());
                             } catch (\Exception $e) {
                                 // We will show this as floating message on page reload