Discovery service based on proto endpoint #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add try-catch block to control exceptions on run function * Change proto generation script spinner appearance for a better look
* Add proto files fetching node script * Update README with specifics on how to fetch proto files * Add axios dependency to be able make HTTP requests * Add metrics proto file to proto directory
* Update gen-proto-code script to use protoc binary. * Update npm scripts. * Update README. * Update dependencies
* Add a microservices information fetching method, deserializing a meesaged based on the proto associated with that endpoint. * Consume that service on the app main component. * Set an environment variable that points to that microservices and nodes discovery information. This closes #13.
anamariamv
approved these changes
Nov 16, 2017
build-scripts/fetch-proto.js
Outdated
| const urlObject = new URL(arg); | ||
| return urlObject; | ||
| } catch (e) { | ||
| // throw new Error(`Error: ${arg} is not a valid URL path`); |
There was a problem hiding this comment.
Adressed on 59ef685
build-scripts/fetch-proto.js
Outdated
| }) | ||
| .catch((error) => { | ||
| spinner.fail(`Error connecting to: ${error.config.url}`); | ||
| // shell.echo(`Error connecting to: ${error.config.url}`); |
There was a problem hiding this comment.
Adressed on 59ef685
src/environments/environment.prod.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| export const environment = { | |||
| production: true, | |||
| // metricsEndpoint: 'ws://localhost:8080/metrics' | |||
| metricsEndpoint: 'ws://localhost:3000' | |||
| metricsEndpoint: 'ws://localhost:3000', | |||
There was a problem hiding this comment.
Adressed on 59ef685
src/environments/environment.ts
Outdated
| @@ -6,5 +6,6 @@ | |||
| export const environment = { | |||
| production: false, | |||
| // metricsEndpoint: 'ws://localhost:8080/metrics' | |||
| metricsEndpoint: 'ws://localhost:3000' | |||
| metricsEndpoint: 'ws://localhost:3000', | |||
There was a problem hiding this comment.
Adressed on 59ef685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fetch-proto script
Use google-protobuf JS runtime
Fix error message on gen-proto-code script
Add JS generated classes from proto descriptors
Add microservices discovery service
This closes #13