Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract handle_method_call from method_missing #550

Closed

Conversation

wasabigeek
Copy link
Contributor

Continues the refactoring started in #549 on the road to better keyword args matching. This is part of a refactor sketched out here.

The key change is to pass arguments and the block directly instead of re-splatting them. That way, we would only need to set ruby2_keywords at the edges, instead of with each splat (for contrast, see initial spike, where ruby2_keywords had to be set at multiple layers).

The extracting of handle_method_call is not strictly necessary, but it makes it clearer that method_missing is just one of the possible entry points for a method call.

@floehopper
Copy link
Member

@wasabigeek

This looks good to me 👍

For some reason CircleCI didn't seem to run a build for this PR, so I ended up pushing up a tracking branch to trigger this build. I also took the opportunity to amend the commit note to include the notes from the PR description.

Merged manually in 6a09a37.

@floehopper floehopper closed this Sep 17, 2022
@wasabigeek wasabigeek deleted the separate-handle-method-call branch September 17, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants