Extract handle_method_call from method_missing #550
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the refactoring started in #549 on the road to better keyword args matching. This is part of a refactor sketched out here.
The key change is to pass arguments and the block directly instead of re-splatting them. That way, we would only need to set
ruby2_keywords
at the edges, instead of with each splat (for contrast, see initial spike, whereruby2_keywords
had to be set at multiple layers).The extracting of
handle_method_call
is not strictly necessary, but it makes it clearer thatmethod_missing
is just one of the possible entry points for a method call.