fix issue 12 #13
Open
fix issue 12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been merged? It's still crashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes the following problems mentioned in this comment of issue 12:
--haroption fromyarn install, this option doesn't seem to work anymore. According to the yarn install documentation it seems to create a HTTP archive. It seems this archive is not required to install the plugin.Additional changes:
The minimum PostgreSQL version supported by Gitlab v14 is version 12. Somewhere (I cannot remember where) I read it the default Postgres version (on Freebsd?) is v13. This fix changes the Postgres database from v12 to v13. I tested this fix on release 12.3-RELEASE Freebsd jail. The original gitlab.json plugin requires 12.2-RELEASE. I believe this plugin has to change too?
@william-gr or @miwi-fbsd could you please have a look at this pull request and merge the fix? Thanks