Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citations with and without nominative reporters are not considered equal #154

Open
mattdahl opened this issue Jul 7, 2023 · 1 comment

Comments

@mattdahl
Copy link
Contributor

mattdahl commented Jul 7, 2023

Consider Marbury v. Madison:

cite1 = '5 U.S. 137'
cite2 = '5 U.S. (1 Cranch) 137'

hash(get_citations(cite1)[0]) == hash(get_citations(cite2)[0])  # Returns False, but True is expected

I think that these two citations should be treated equally. (The core reporter, volume, and page keys match, but the second one has extra reporter_nominative and volume_nominative keys.)

This is related to the proposed hashing changes in #148. @overmode, I realize that PR has been languishing, in large part to my poor guidance earlier, but I might move forward on fixing this myself if that's okay with you.

@mlissner
Copy link
Member

mlissner commented Jul 7, 2023

Yeah, that seems right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants