Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Scenarios for handling of active users #199

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Test: Scenarios for handling of active users #199

merged 2 commits into from
Dec 7, 2023

Conversation

miskopo
Copy link
Member

@miskopo miskopo commented Dec 1, 2023 •
edited
Loading

Test: Scenarios for handling of active users

Test creating, disabling, deleting, preserving and activating workflows
within active-users page.

@miskopo miskopo added the WIP Work in Progress (do not merge) label Dec 1, 2023
@miskopo miskopo linked an issue Dec 1, 2023 that may be closed by this pull request
[Testing] Create user story for test_userintegration test #85
Closed
@miskopo miskopo force-pushed the gherkin_testing branch 6 times, most recently from dcbe289 to 08b2010 Compare December 4, 2023 16:19
@miskopo miskopo requested a review from carma12 December 4, 2023 16:21
@miskopo miskopo changed the title test_user: Port existing tests Test: Scenarios for handling of active users Dec 5, 2023
@miskopo miskopo added needs-review This PR is waiting on a review tests PR related to testing and removed WIP Work in Progress (do not merge) labels Dec 5, 2023
miskopo
miskopo commented Dec 5, 2023
View reviewed changes
tests/features/active_users_handling.feature Outdated Show resolved Hide resolved
tests/features/steps/common.ts Outdated Show resolved Hide resolved
@miskopo miskopo force-pushed the gherkin_testing branch 2 times, most recently from 0bf9006 to 02f7d13 Compare December 5, 2023 13:05
carma12
carma12 requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@carma12 carma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Also:

  • I was not able to find the Re-enable multiple users at once test in the active_users_habdling.feature. Am I looking into the right place?
  • It would be also nice to create a test to check the 'Rebuild auto membership' functionality located in the kebab options (next to the main action buttons).

cypress/support/commands.ts Outdated Show resolved Hide resolved
cypress/support/e2e.ts Outdated Show resolved Hide resolved
@miskopo
Upgrade Cypress and Cucumber preprocessor
e5b61ae 
Upgrade Cypress and adjust its configuration. Upgrade
cypress-cucumber-preprocessor to v19.2.0.

Signed-off-by: Michal Polovka <[email protected]>
@miskopo
Copy link
Member Author

miskopo commented Dec 6, 2023

Added some comments. Also:

* I was not able to find the `Re-enable multiple users at once` test in the `active_users_habdling.feature`. Am I looking into the right place?

* It would be also nice to create a test to check the 'Rebuild auto membership' functionality located in the kebab options (next to the main action buttons).

Ad point 1: It's strange, I can see the test code in active_users_handling.feature, test results in Cypress run and I can feel its presence in the Force.
Ad point 2: I have added Rebuild auto membership test.
During testing of point 2, I have found out, that you get success even if no users are selected. Old UI behaves the same way, however, I am not sure this is desired.

@miskopo
Test: Scenarios for handling of active users
7cd7a10 
Test creating, disabling, deleting, preserving and activating workflows
within active-users page.

Signed-off-by: Michal Polovka <[email protected]>
@carma12
Copy link
Collaborator

carma12 commented Dec 7, 2023

Ad point 1: It's strange, I can see the test code in active_users_handling.feature, test results in Cypress run and I can feel its presence in the Force.
Weird... How is the test being run? Maybe it is defined somewhere else in the code?

Ad point 2: I have added Rebuild auto membership test. During testing of point 2, I have found out, that you get success even if no users are selected. Old UI behaves the same way, however, I am not sure this is desired.
This is the normal behavior. You either can rebuild auto membership by selecting users (that will be applied for those specific users) or by selecting none (that will be applied for all users).

carma12
carma12 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@carma12 carma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added some notes as FYI

cypress.config.ts Show resolved Hide resolved
cypress/support/commands.ts Show resolved Hide resolved
@miskopo miskopo added ack Pull Request approved, it can be merged and removed needs-review This PR is waiting on a review labels Dec 7, 2023
@miskopo miskopo merged commit 7a79621 into freeipa:main Dec 7, 2023
2 checks passed
@miskopo miskopo deleted the gherkin_testing branch December 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carma12 carma12 carma12 approved these changes

Assignees

@miskopo miskopo

@b3lix b3lix

Labels
ack Pull Request approved, it can be merged tests PR related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Testing] Create user story for test_userintegration test
3 participants
@miskopo @carma12 @b3lix