Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyo3 version #7432

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

surfingreg
Copy link

Status

Ready for review

Description of Changes

Testing

How should the reviewer test this PR?
- Standard:

Fastest/narrowest test of changed Rust code:
cd securedrop
cargo test --package redwood

Standard dev/docker environment:
cd securedrop
make dev                                               # run development servers
make test

Write out any special testing steps here.
None required

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
    I don't think so.

  2. New installs.
    No.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

"make test" fails on some [ar] locales. Is this to be expected? Is there anything I can do to correct the test locally? It passes all others.

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

  • I have updated AppArmor rules to include the change

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Not applicable. Existing tests suffice.

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a reference to a production code dependency:

Production code dependencies are defined in:

  • admin/requirements.in
  • admin/requirements-ansible.in
  • securedrop/requirements/python3/requirements.in
  • securedrop/requirements/python3/translation.in (used in the build
    container)

I'm not sure. I changed one Rust dependency in redwood/Cargo.toml. It passes cargo vet and cargo audit.

If you changed another requirements.in file that applies only to development
or testing environments, then no diff review is required, and you can skip
(remove) this section.

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like[/recommend] someone else to do the diff review [since I'm brand new here]
  • I am silencing an alert related to a production dependency, because (please explain below):

@surfingreg surfingreg requested a review from a team as a code owner January 30, 2025 22:49
@legoktm
Copy link
Member

legoktm commented Jan 31, 2025

Thanks for submitting @surfingreg; the Python CI all looks good \o/. The rust checks are flagging that rustfmt has some changes to make if you want to run cargo fmt.

The cargo-vet review part will be handled by us maintainers, so don't worry about that. I do just want to set expectations that our current focus is on getting SecureDrop 2.12.0 out the door; I/we will plan to get to this for the 2.13.0 release cycle.

@legoktm legoktm added this to the SecureDrop 2.13.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pyo3 to latest
2 participants