Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run all non-staging tests on i18n- branches #6923

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

cfm
Copy link
Member

@cfm cfm commented Aug 16, 2023

Status

Ready for review

Description of Changes

Fixes #6876 by un-skipping on i18n- branches all the testing jobs we run normally on pull requests and develop.

Not implemented here:

Testing

  • CI passes, including all of:
    • app-tests
    • app-page-layout-tests
    • translation-tests

Deployment

CI-only; no deployment considerations.

staging-test-with-rebase is still "only"-restricted to "stg-" and
"release/" branches, but "i18n-" branches will no longer specifically
skip any testing jobs.
@cfm cfm added the i18n Anything related to translation or internationalization of SecureDrop label Aug 16, 2023
@cfm cfm requested a review from a team as a code owner August 16, 2023 20:22
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI passes, including all of:
    • app-tests
    • app-page-layout-tests
    • translation-tests

Thanks @cfm :)

@rocodes rocodes merged commit ba04ad7 into develop Aug 21, 2023
@legoktm legoktm deleted the i18n-with-ci branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything related to translation or internationalization of SecureDrop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n branches and/or repository should run full CI workflow
2 participants