Upgrade admin tests and container for bullseye / Python 3.9 #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've moved to Tails 5, which is based on Debian Bullseye and uses Python 3.9. Additionally: * Use a plain Debian image instead of a CircleCI one * Use `apt update` instead of `apt-get update`, because it automatically accepts releaseinfo changes * Drop the `$2>/dev/null`, which doesn't appear to do anything. I assume it's a typo for `2>/dev/null` to hide stderr, except all the output is on stderr, so we probably don't want that. Refs #6635.
We've moved to Tails 5, which is based on Debian Bullseye and uses Python 3.9. Some dependencies are dropped because they were only needed for older Python versions. Additionally: * Stop installing lsb-release, we dropped it in #6530. * Use a plain Debian image instead of a CircleCI one Fixes #6635.
We primarily needed to upgrade pyflakes for Python 3.8 compatibility (PyCQA/pyflakes#367), but upgrading flake8 also meant pulling in a newer pylint since they have a common dependency, so here we are.
eaon
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Tails 5 is Debian Bullseye / Python 3.9, this updates the CI/dev environment for things that run on Tails to match.
Fixes #6635.
See commit messages for further details.
Testing
How should the reviewer test this PR?
make -C admin testlocallyDeployment
Any special considerations for deployment? No, these are all CI/dev-only changes.
Checklist
make -C admin test) pass in the admin development container