-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pyo3 to latest #7277
Comments
Hi, I have a PR ready to go for this. But, I wanted to check in before I sprang it on you, this being my first contribution. It brings the PyO3 version up to 0.23.4 from 0.18.0. develop...surfingreg:securedrop:develop-bump-pyo3-version The Rust tests pass. I'm less confident about what will happen outside Rust. Mainly because, in alignment with the newer pyo3 API, I changed the signature for redwood() (https://pyo3.rs/v0.23.4/function.html)...
pyo3 migration ref: It does also bump us past this, though it doesn't appear relevant(?). Thoughts? Thanks! |
Hi @surfingreg! Thanks for working on this.
The Python application tests should be comprehensive enough if you want to run it locally or in CI. As long as it's exporting roughly the same thing, it should just work.
That seems to be a regression in 0.23.0, so we weren't affected. Probably wouldn't have affected us too bad since we only have one version of Python installed in the environment where we build packages. |
Description
We probably got a bit lucky in that https://rustsec.org/advisories/RUSTSEC-2024-0378 only affects newer versions of pyo3 and not older ones. In terms of our major Rust dependencies, pyo3 is probably the most outdated one since it's a big review burden (and not used by any other audits we import IIRC).
We should proactively get close to latest so we can review it at our leisure (including splitting the load) instead of reacting to an issue in a hurry.
The text was updated successfully, but these errors were encountered: