Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Avoid repeating Fedora version in specific test #926

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Nov 28, 2023

Status

Ready for review

Description of Changes

We have the CURRENT_FEDORA_VERSION/TEMPLATE constants for this purpose.

Testing

  • CI passes + visual review

Deployment

Any special considerations for deployment? No, test only

Checklist

  • All tests (make test) pass in dom0

@mig5
Copy link
Contributor

mig5 commented Nov 28, 2023

FYI that:

  1. The CI build failed on INFO:[2023-11-28-16:57:03:931867] qvm-template: error: Template 'securedrop-workstation-bullseye' not found . That sounds very much like securedrop-workstation-bullseye template install fails after uninstall #813 (a timing issue?) whereby I think a solution was found but might not have been implemented yet?

  2. I have triggered a redelivery of the webhook to cause the CI to run again against this commit. The build is taking longer so far, which gives me some hope that it might be working this time. We'll see soon!

EDIT: Hooray! https://ws-ci-runner.securedrop.org/2023-11-28-184849455485.log.txt

We have the CURRENT_FEDORA_VERSION/TEMPLATE constants for this purpose.
@zenmonkeykstop
Copy link
Contributor

LGTM but rebasing, will merge if CI is good.

@zenmonkeykstop zenmonkeykstop self-assigned this Jan 16, 2024
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop merged commit 69d7efd into main Jan 16, 2024
8 checks passed
@zenmonkeykstop zenmonkeykstop deleted the dry-tests-fedora branch January 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants