Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Qubes OS R4.2 related changes #897

Closed
wants to merge 6 commits into from
Closed

WIP: Qubes OS R4.2 related changes #897

wants to merge 6 commits into from

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Jun 2, 2023

Description of Changes

TK

Testing

TK

Deployment

TK

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0
  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec
  • I would appreciate help with the documentation

@eaon
Copy link
Contributor Author

eaon commented Jun 2, 2023

As far as I understand sd-ci-runner will always fail as it's only set up to test with Qubes 4.1. @maeve-fpf @mig5 is there a way to exempt PRs/branches from testing? Because this just wastes CPU cycles for 0 benefit.

@mig5
Copy link
Contributor

mig5 commented Jun 4, 2023

@eaon there isn't any way for me to exempt branches from triggering the webhook on Github's side. However, I can easily add logic on the receiving end of the webhook to skip CI based on some arbitrary 'rule' of our own making - it would have to be something like a naming convention of the branch. This means it'd just be the onus on 'us' to adhere to that rule/be consistent.

Can I suggest that you use a prefix like skip-ci/ in the branch name when you'd want to skip it? (I don't think making it specific to Qubes 4.2 makes sense as we might want to do it for other things in future).

I imagine this to be a rare occurrence and we could even potentially reverse the logic at some point to target specific CI backends for different OS versions (e.g have a CI machine running an RC release of whatever Qubes version) - but we're not there yet.

(Otherwise: I wouldn't worry about 'wasting CPU cycles' too much, there is no real cost for running this CI right now... if you want to just ignore the whole thing that's fine by me too.. this failed job was only 2 minutes of activity for the CI machine)

@eaon
Copy link
Contributor Author

eaon commented Jun 5, 2023

2 minutes isn't as bad as I had thought 🙂 But yeah, a skip-ci/ prefix sounds great regardless, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants