Add cups service/feature to sd-devices-dvm
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of bullseye, Qubes requires the cups service/feature to be set in dom0 for systemd to successfully start cups.service inside the VM. sd-devices inherits this from sd-devices-dvm.
5 tasks
sssoleileraaa
previously approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Holding off on merging until freedomofpress/securedrop-export#96 is merged
eloquence
approved these changes
Jul 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As of bullseye, Qubes requires the cups service/feature to be set in
dom0 for systemd to successfully start
cups.serviceinside the DispVM.sd-devicesinherits this fromsd-devices-dvm.Fixes #794
Towards #600
Testing
make devqvm-features sd-devices-dvmandqvm-features sd-devices, both of which showservice.cups 1Checklist
make test) pass indom0