Adds build_path checks for deb pkg reprotest #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #231 we noticed that the filesystem path used to build the debian
packages was breaking reproducibility. That's due to the filepath being
recorded inside
direct_url.json
, as stipulated by PEP610.Also relevant is PEP427, which describes the
RECORD
file for wheels.Here we remove that file, as well, to ensure full reproducibility
regardless of path.
Testing
To evaluate change in the problematic behavior reported in #231, clone this branch fresh in a few different locations, e.g. in DispVMs, and try rebuilding. Make sure that the absolute path of the repo is different between builds! The checksum of the .deb packages should be identical.