Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Fedora 38 #840

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Drop support for Fedora 38 #840

merged 1 commit into from
Jun 20, 2024

Conversation

almet
Copy link
Member

@almet almet commented Jun 20, 2024

Fedora 38 is EOL since 21 May 2024, so this removes the specific branches we had checking for it, and updates the related instructions.

@almet almet force-pushed the 2024-06-remove-fedora-38 branch 2 times, most recently from 7cf7555 to 0f4e516 Compare June 20, 2024 13:33
@apyrgio
Copy link
Contributor

apyrgio commented Jun 20, 2024

I see two places that still refer to Fedora 38:

$ git grep -i fedora | grep 38
BUILD.md:   > :bulb: Alternatively, you can use your base Fedora 38 template in the
[...]
dev_scripts/qa.py:class QAFedora38(QAFedora):

The first should change to refer to Fedora 40. What we're saying to the user there is that they can install Dangerzone on their base Fedora 40 template, instead of a separate one. For the second reference, we should just remove it.

@almet almet force-pushed the 2024-06-remove-fedora-38 branch 2 times, most recently from 18cd9ce to 632bdde Compare June 20, 2024 14:42
@almet
Copy link
Member Author

almet commented Jun 20, 2024

🔖 Hey, thanks for catching this up. Mentally bookmarking the -i flag and the grep on the version number for later reference.

Fedora 38 is EOL since 21 May 2024, so this removes the specific branches
we had checking for it, and updates the related instructions.
@almet almet force-pushed the 2024-06-remove-fedora-38 branch from 632bdde to c2a47ec Compare June 20, 2024 15:08
@apyrgio
Copy link
Contributor

apyrgio commented Jun 20, 2024

Oh nice, you found another instance of Fedora 38 as well. Thanks for the changes, feel free to merge.

@almet almet merged commit c2a47ec into main Jun 20, 2024
50 checks passed
@almet almet deleted the 2024-06-remove-fedora-38 branch June 20, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants