build: bump the minimum python version to 3.9 #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
minimum-python-3.9
branch
2 times, most recently
from
180a20b to
9f2fb9c
Compare
This was referenced Jun 3, 2024
apyrgio
reviewed
Jun 3, 2024
almet
force-pushed
the
minimum-python-3.9
branch
5 times, most recently
from
4fc74a2 to
2689774
Compare
The minimum python version when installing from source is now python 3.9, as Pyside6 6.7.1 dropped support for python 3.8 (see #780 for more information). On Debian-derivatives distributions, the minimum Python version is now set to 3.8. In practice, because Pyside6 is not packaged for Debian, we use Pyside2 [0], which is why we can relax the python version requirement. In practice, when installing from source on an environment where python3.9 is not the default python, poetry will look for it and use it if available > For various reasons, this Python version might not be compatible with > the python range supported by the project. In this case, Poetry will > try to find one that is and use it. > > [Poetry docs](https://python-poetry.org/docs/managing-environments/) On Ubuntu Focal (20.04) where Python 3.9 is not installed by default, it is possible to install it using the `python3.9` package. Additionally, In version 1.24.3, PyMuPDF changed its package name from `fitz` to `pymupdf` [2], resulting in a breakage on how it is installed in our container. This is now fixed. [0] More information on how Pyside6 packaging affects dangerzone on #221 [1] See [the current status of Pyside6 packaging](https://repology.org/ project/python:pyside6/packages) [2] PyMuPDF changelog: https://pymupdf.readthedocs.io/en/latest/changes.html#change-log
apyrgio
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the minimum python version to 3.9 when installing from source, and to 3.8 when installing in Debian-related distributions.
The minimum python version when installing from source is now python
3.9, as Pyside6 6.7.1 dropped support for python 3.8 (see #780 for more
information).
On Debian-derivatives distributions, the minimum Python version is now
set to 3.8. In practice, because Pyside6 is not packaged for Debian, we
use Pyside2 [0], which is why we can relax the python version requirement.
In practice, when installing from source on an environment where
python3.9 is not the default python, poetry will look for it and use it
if available
On Ubuntu Focal (20.04) where Python 3.9 is not installed by default,
it is possible to install it using the
python3.9package.[0] More information on how Pyside6 packaging affects dangerzone on #221
[1] See the current status of Pyside6 packaging