Add design document for gVisor integration #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
approved these changes
May 24, 2024
|
I've added some small fixups that cover some points we discussed with @EtiennePerot, and the fact that we no longer disable seccomp when using Docker on Windows / macOS. |
EtiennePerot
reviewed
Jun 8, 2024
EtiennePerot
reviewed
Jun 8, 2024
EtiennePerot
reviewed
Jun 8, 2024
|
@almet I'm squashing the fixups. Are we good to merge? |
Move the documentation on how to create and use containerized Dangerzone environments under `docs/developer`, which seems like a more natural place than a README under `dev_scripts/`.
Add a design document for the update notifications mechanism, adapted from the write-up in the original GitHub issue. Refs #189
Add a design document for the gVisor integration, which is currently under review. The associated pull request has lots of architectural discussions about integrating gVisor, so in this document we collect them all in one place. Refs #590
apyrgio
force-pushed
the
2024-05-gvisor-doc
branch
from
f92e45c to
277b167
Compare
|
Sure, go ahead ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a design document for the gVisor integration, based on the discussions we had in #590. Also, add a few more design documents that are scavenged from other GitHub issues / dirs.