Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qubes: Clean up temporary files #575

Closed
apyrgio opened this issue Oct 4, 2023 · 0 comments · Fixed by #579
Closed

Qubes: Clean up temporary files #575

apyrgio opened this issue Oct 4, 2023 · 0 comments · Fixed by #579
Assignees
@apyrgio
Labels
bug Something isn't working P:Qubes QubesOS integration
Milestone
0.5.0

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Oct 4, 2023

Currently, our Qubes isolation provider and the PixelsToPdf converter use /tmp/dangerzone and /tmp/page* paths as their temporary storage space. The problem is that these paths are not cleared after a conversion, leading to stale files left behind.
@apyrgio apyrgio added bug Something isn't working P:Qubes QubesOS integration labels Oct 4, 2023
@apyrgio apyrgio self-assigned this Oct 4, 2023
@apyrgio apyrgio added this to the 0.5.0 milestone Oct 4, 2023
apyrgio added a commit that referenced this issue Oct 4, 2023
@apyrgio
conversion: Allow using a temp dir other than /tmp
f37d89f 
Extend the PixelsToPDF converter by adding an additional `tempdir`
argument. This argument can be used to make the conversion use a
different temporary directory other than `/tmp`.

For containers, this extra arguments makes no difference, as it won't be
used. For Qubes, this argument will allow storing files in a temporary
dir that will be cleaned up once the conversion completes. Previously,
these files would linger in the user's `/tmp`.

Refs #575
apyrgio added a commit that referenced this issue Oct 4, 2023
@apyrgio
qubes: Clean up temporary files
881d47c 
Create a temporary dir before the conversion begins, and store every
file necessary for the conversion there. We are mostly concerned about
the second stage of the conversion, which runs in the host. The first
stage runs in a disposable qube and cleanup is implicit.

Fixes #575
@apyrgio apyrgio mentioned this issue Oct 4, 2023
Merged
@apyrgio apyrgio closed this as completed in bdf3f8b Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apyrgio apyrgio

Labels
bug Something isn't working P:Qubes QubesOS integration
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

qubes: Clean up temporary files freedomofpress/dangerzone
1 participant
@apyrgio