Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Intermediate Directories are cleaned in the case of exceptions #317

Closed
deeplow opened this issue Jan 25, 2023 · 0 comments · Fixed by #336
Closed

Ensure Intermediate Directories are cleaned in the case of exceptions #317

deeplow opened this issue Jan 25, 2023 · 0 comments · Fixed by #336
Assignees
@deeplow
Milestone
0.4.1

Comments

@deeplow
Copy link
Contributor

deeplow commented Jan 25, 2023

When a document fails to convert for some reason, dangerzone doesn't remove its temporary directory.
@apyrgio apyrgio added this to the 0.4.1 milestone Jan 30, 2023
@apyrgio apyrgio self-assigned this Jan 30, 2023
@deeplow deeplow assigned deeplow and unassigned apyrgio Feb 1, 2023
apyrgio added a commit that referenced this issue Feb 8, 2023
@apyrgio
container: Do not leave stale temporary dirs
ebef341 
Do not leave stale temporary directories when conversion fails
unexpectedly. Instead, wrap the conversion operation in a context
manager that wipes the temporary dir afterwards.

Fixes #317
@apyrgio apyrgio mentioned this issue Feb 8, 2023
Merged
apyrgio added a commit that referenced this issue Feb 8, 2023
@apyrgio
container: Do not leave stale temporary dirs
94e30d9 
Do not leave stale temporary directories when conversion fails
unexpectedly. Instead, wrap the conversion operation in a context
manager that wipes the temporary dir afterwards.

Fixes #317
apyrgio added a commit that referenced this issue Feb 15, 2023
@apyrgio
container: Do not leave stale temporary dirs
ed7e07a 
Do not leave stale temporary directories when conversion fails
unexpectedly. Instead, wrap the conversion operation in a context
manager that wipes the temporary dir afterwards.

Fixes #317
apyrgio added a commit that referenced this issue Feb 15, 2023
@apyrgio
container: Do not leave stale temporary dirs
8fc68aa 
Do not leave stale temporary directories when conversion fails
unexpectedly. Instead, wrap the conversion operation in a context
manager that wipes the temporary dir afterwards.

Fixes #317
@apyrgio apyrgio mentioned this issue Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeplow deeplow

Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Improve temporary directory handling freedomofpress/dangerzone
2 participants
@apyrgio @deeplow