Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"New Window" does not work in 0.3.2 #204

Closed
deeplow opened this issue Sep 15, 2022 · 3 comments
Closed

"New Window" does not work in 0.3.2 #204

deeplow opened this issue Sep 15, 2022 · 3 comments
Milestone
0.4.0

Comments

@deeplow
Copy link
Contributor

deeplow commented Sep 15, 2022

When one opens a new window from the tray menu, on the 0.3.2 release we get the following error:

Traceback (most recent call last):
  File "/home/user/dangerzone/dangerzone/gui/__init__.py", line 91, in select_document
    and windows[list(windows.keys())[0]].common.input_filename == None
  File "/home/user/dangerzone/dangerzone/common.py", line 23, in input_filename
    raise RuntimeError("Input filename has not been set yet.")
RuntimeError: Input filename has not been set yet.
@deeplow
Copy link
Contributor Author

deeplow commented Sep 15, 2022

Even though this is a regression from the previous release, from my testing on 0.3.1 (previous release) an additional bug related to this had gone unnoticed. I have reported it now.

So, in short, even though this is a regression in terms of UX (window buttons don't work), it is not a regression compared to the previous release in terms of functionality.

@eloquence eloquence added this to the 0.4.0 milestone Sep 15, 2022
deeplow added a commit that referenced this issue Sep 19, 2022
@deeplow
simplify 'new window' logic
9d6c997 
And also deals with the document creation logic in the main() of
GUI and CLI instead of doing in main_window() on the CLI.

Fixes #204
@deeplow
Copy link
Contributor Author

deeplow commented Sep 20, 2022

Oddly this doesn't seem to affect MacOS

@deeplow deeplow mentioned this issue Sep 20, 2022
Closed
@apyrgio apyrgio mentioned this issue Oct 4, 2022
Merged
@eloquence
Copy link
Member

The "New Window" systray feature no longer exists in the development version and has been replaced with multi-document support, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@eloquence @deeplow