-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building on M1 macs #177
Comments
Confirmed by @gmarmstrong in #161 (comment). |
To clarify, Dangerzone runs fine on m1 macs. What I can't seem to do is to setup the development environment due to dependency issues (shiboken). |
Our current approach to may be : try:
Pyside2...
except ImportError:
PySide6... or maybe we should do with platform conditions. On Poetry - find a way to have platform-specific dependencies - Add PySide6 for MacOS. |
Update regarding the final implementation of this feature:
|
Replace PySide2-stubs with types-PySide2, both of which are projects that provide PySide2 typing hints, for the following reasons: 1. types-PySide2 is more complete and allows us to ditch some 'type: ignore' comments for Mypy. 2. PySide2-stubs also brings PySide2 as a dependency, which cannot be installed in MacOS M1 machines. Refs #177
Replace PySide2-stubs with types-PySide2, both of which are projects that provide PySide2 typing hints, for the following reasons: 1. types-PySide2 is more complete and allows us to ditch some 'type: ignore' comments for Mypy. 2. PySide2-stubs also brings PySide2 as a dependency, which cannot be installed in MacOS M1 machines. Refs #177
Replace PySide2-stubs with types-PySide2, both of which are projects that provide PySide2 typing hints, for the following reasons: 1. types-PySide2 is more complete and allows us to ditch some 'type: ignore' comments for Mypy. 2. PySide2-stubs also brings PySide2 as a dependency, which cannot be installed in MacOS M1 machines. Refs #177
Replace PySide2-stubs with types-PySide2, both of which are projects that provide PySide2 typing hints, for the following reasons: 1. types-PySide2 is more complete and allows us to ditch some 'type: ignore' comments for Mypy. 2. PySide2-stubs also brings PySide2 as a dependency, which cannot be installed in MacOS M1 machines. Refs freedomofpress#177
Replace PySide2-stubs with types-PySide2, both of which are projects that provide PySide2 typing hints, for the following reasons: 1. types-PySide2 is more complete and allows us to ditch some 'type: ignore' comments for Mypy. 2. PySide2-stubs also brings PySide2 as a dependency, which cannot be installed in MacOS M1 machines. Refs freedomofpress#177
The
shiboken2
package fails to install on m1s because it has no builds for ARM architectures on macbooks (no available wheels).When running
poetry install
on an m1 macbook:Originally posted by @deeplow in #172 (comment)
The text was updated successfully, but these errors were encountered: