Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

chore: check integrationStatus before trying to use calendar #2354

Conversation

gikf
Copy link
Member

@gikf gikf commented Feb 7, 2023

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

  • Adds check of the integrationStatus before using calendar.
  • Change isn't that big as it might look like, external api wouldn't be actually used anyway, but I find more sensible to do the check first, instead of letting the service call error.

@ghost
Copy link

ghost commented Feb 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gikf, I think it makes sense to put the burden on our db rather than sending requests to Google that we know will fail.

LGTM 👍

@ojeytonwilliams ojeytonwilliams added this pull request to the merge queue Feb 14, 2023
Merged via the queue into freeCodeCamp:main with commit 4af056a Feb 14, 2023
@gikf gikf deleted the chore/check-integrationStatus-before-calling-service branch February 14, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants