Refactor frontend, relates to issue #35 #43
Conversation
|
Hi @LaumiH Thanks for your contribution, |
|
Hi @ericboy0224 Please help to review this PR when you feel free. |
| return | ||
| } | ||
| //msisdnTemp += 1 | ||
| } |
There was a problem hiding this comment.
Fix:
gofumpt -w backend/WebUI/api_webui.go
| // sendResponseToClient(c, resp) | ||
| // } else { | ||
| // sendResponseToClientFilterTenant(c, resp, tenantId) | ||
| // } |
There was a problem hiding this comment.
Do we need to remove unused part?
There was a problem hiding this comment.
I leave that to you, I don't want to refactor too much in the backend.
|
|
||
| <div class="clearfix"></div> | ||
| <script src="https://cdn.jsdelivr.net/npm/react/umd/react.production.min.js" crossorigin></script> |
There was a problem hiding this comment.
I suggest that do not use CDN resources in the webconsole.
Because in some use cases, our user could deploy the free5GC in their private network without internet.
* fix: CSRF vulnerability * Use jwtKey (256 bytes random string) as JWT Signature Private Key * Delete add Add admin's tenant & user when initializing Backend fix linter * fix: exposed password in UserModal * add confirmPassword in UserModal * use crypto/rand instead of math/rand * Use http.StatusUnauthorized instead of http.StatusNotFound when CheckAuth failed. * add InitJwtKey()
|
Hi @LaumiH Thank you. |
…nto refactor-frontend-pr
|
Sad to hear that! Should you ever want to reconsider this decision, you know where to find my repo :) Come check out the new functionality, too. Cheers, |
Hi all,
with this PR I want to share my refactored webconsole frontend. I made small changes and fixes in the backend as well.
This is a non-exhaustive list of the improvements and changes I made:
react hooks form, add more validation and improved feedback for usersI plan to subsequently add my newly developed functionality for the webconsole to this PR.
Please let me know what you think, add comments and requests for changes!