Skip to content

Commit

Permalink
Fixed ci-lint error
Browse files Browse the repository at this point in the history
  • Loading branch information
saileshvvr committed Feb 4, 2024
1 parent f52dc9c commit acf2806
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
4 changes: 0 additions & 4 deletions internal/context/ngap_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func HandlePDUSessionResourceSetupResponseTransfer(b []byte, ctx *SMContext) (er
resourceSetupResponseTransfer := ngapType.PDUSessionResourceSetupResponseTransfer{}

err = aper.UnmarshalWithParams(b, &resourceSetupResponseTransfer, "valueExt")

if err != nil {
return err
}
Expand Down Expand Up @@ -109,7 +108,6 @@ func HandlePDUSessionResourceSetupUnsuccessfulTransfer(b []byte, ctx *SMContext)
resourceSetupUnsuccessfulTransfer := ngapType.PDUSessionResourceSetupUnsuccessfulTransfer{}

err = aper.UnmarshalWithParams(b, &resourceSetupUnsuccessfulTransfer, "valueExt")

if err != nil {
return err
}
Expand Down Expand Up @@ -196,7 +194,6 @@ func HandlePathSwitchRequestSetupFailedTransfer(b []byte, ctx *SMContext) (err e
pathSwitchRequestSetupFailedTransfer := ngapType.PathSwitchRequestSetupFailedTransfer{}

err = aper.UnmarshalWithParams(b, &pathSwitchRequestSetupFailedTransfer, "valueExt")

if err != nil {
return err
}
Expand Down Expand Up @@ -229,7 +226,6 @@ func HandleHandoverRequestAcknowledgeTransfer(b []byte, ctx *SMContext) (err err
handoverRequestAcknowledgeTransfer := ngapType.HandoverRequestAcknowledgeTransfer{}

err = aper.UnmarshalWithParams(b, &handoverRequestAcknowledgeTransfer, "valueExt")

if err != nil {
return err
}
Expand Down
14 changes: 8 additions & 6 deletions internal/sbi/consumer/subscriber_data_management.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import (
)

func SDMGetSmData(smCtx *smf_context.SMContext,
smPlmnID *models.PlmnId) (problemDetails *models.ProblemDetails, err error) {
smPlmnID *models.PlmnId,
) (problemDetails *models.ProblemDetails, err error) {
// Query UDM
if problemDetails, err := SendNFDiscoveryUDM(); err != nil {

Check failure on line 20 in internal/sbi/consumer/subscriber_data_management.go

View workflow job for this annotation

GitHub Actions / lint (1.18)

shadow: declaration of "problemDetails" shadows declaration at line 18 (govet)
smCtx.Log.Warnf("Send NF Discovery Serving UDM Error[%v]", err)
Expand Down Expand Up @@ -63,12 +64,12 @@ func SDMGetSmData(smCtx *smf_context.SMContext,
err = localErr
}

return
return problemDetails, err
}

func SDMSubscribe(smCtx *smf_context.SMContext, smPlmnID *models.PlmnId) (
problemDetails *models.ProblemDetails, err error) {

problemDetails *models.ProblemDetails, err error,
) {
if !smf_context.GetSelf().Ues.UeExists(smCtx.Supi) {
sdmUri := util.SearchNFServiceUri(smf_context.GetSelf().UDMProfile, models.ServiceName_NUDM_SDM,
models.NfServiceStatus_REGISTERED)
Expand Down Expand Up @@ -117,7 +118,8 @@ func SDMSubscribe(smCtx *smf_context.SMContext, smPlmnID *models.PlmnId) (
}

func SDMUnSubscribe(smCtx *smf_context.SMContext) (problemDetails *models.ProblemDetails,
err error) {
err error,
) {
if smf_context.GetSelf().Ues.IsLastPduSession(smCtx.Supi) {
sdmUri := util.SearchNFServiceUri(smf_context.GetSelf().UDMProfile, models.ServiceName_NUDM_SDM,
models.NfServiceStatus_REGISTERED)
Expand Down Expand Up @@ -158,5 +160,5 @@ func SDMUnSubscribe(smCtx *smf_context.SMContext) (problemDetails *models.Proble
} else {
smf_context.GetSelf().Ues.DecrementPduSessionCount(smCtx.Supi)
}
return
return problemDetails, err
}

0 comments on commit acf2806

Please sign in to comment.