fix: restore intended behavior of nnrf-nfm/v1/nf-instances endpoint #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nnrf-nfm/v1/nf-instances endpoint tried to get request query parameters by extracting the from the request path using c.Params.ByName. This resulted in empty results for nfType and limitParam and thus always returned 400 on every request.
tim-ywliu
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nnrf-nfm/v1/nf-instances endpoint tried to get request query parameters by extracting the from the request path using
c.Params.ByName.This resulted in empty results for
nfTypeandlimitParamand thus always returned 400 on every request.