fix typo in gamma ccall, fix JuliaMath#101

fredrikekre · Jun 24, 2018 · 1b12460 · 1b12460
1 parent 1485740
commit 1b12460
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/gamma.jl b/src/gamma.jl
@@ -714,7 +714,7 @@ lbeta(x::Number, w::Number) = lgamma(x)+lgamma(w)-lgamma(x+w)
 function gamma(x::BigFloat)
     isnan(x) && return x
     z = BigFloat()
-    ccall((:mpfr_lgamma, :libmpfr), Int32, (Ref{BigFloat}, Ref{BigFloat}, Int32), z, x, ROUNDING_MODE[])
+    ccall((:mpfr_gamma, :libmpfr), Int32, (Ref{BigFloat}, Ref{BigFloat}, Int32), z, x, ROUNDING_MODE[])
     isnan(z) && throw(DomainError(x, "NaN result for non-NaN input."))
     return z
 end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -520,6 +520,11 @@ end
         @test typeof(SF.erf(a)) == BigFloat
         @test typeof(SF.erfc(a)) == BigFloat
     end
+
+    # issue #101
+    for i in 0:5
+        @test gamma(big(i)) == gamma(i)
+    end
 end
 
 @testset "Base Julia issue #17474" begin