-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HomeAssistant capability and add Features #6
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes..
Please make sure that all pre-commit tasks runs successfully.
You are right this looks like it qualifies a minor version-bump but version bumping is made during release build (make release
) which will eventually be a release pipeline within github.
Does this fix #3 too? |
I think that may have been sorted with the move to DaikinFactory class instead of the Appliance.factory method linked in the issue description I'm definitely not seeing the same long boot times in my dev environment so I'm hopeful it would |
Co-authored-by: Fredrik Erlandsson <[email protected]>
Co-authored-by: Fredrik Erlandsson <[email protected]>
I have fixed most the pre-commit issues - but i think the pylint is failing due to this pre-commit 5973258 |
The details is outlined here: https://results.[pre-commit.ci](https://results.pre-commit.ci/run/github/757419802/1716528114.uHUD88kaR5eVG68JIn2aiA)/run/github/757419802/1716528114.uHUD88kaR5eVG68JIn2aiA There is something with pylint and netifaces, I can take a look at that. Edit: You need to rebase with latest version on github main. ( |
Fix pylint issues in pre-commit
Thanks a lot @kingy444 ! New version published to https://pypi.org/project/pydaikin/2.12.0/ |
Maybe you want to bump further like 2.12?
Just given the changes they were not insignifigant. I only bumped to 2.11.2 for testing with HomeAssistant
The most signifigant changes made were:
This also supports filter clean / dirty and only returns zones that are enabled on the controller rather than including the zones that are disabled aswell