Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HomeAssistant capability and add Features #6

Merged
merged 21 commits into from
May 24, 2024

Conversation

kingy444
Copy link
Collaborator

Maybe you want to bump further like 2.12?

Just given the changes they were not insignifigant. I only bumped to 2.11.2 for testing with HomeAssistant

The most signifigant changes made were:

  • managing the session entirely within init (and not within update_status)
  • removing the async with for client_session in update_status as this was closing the home assistant entity
  • Error catching on the TaskGroup
  • move from retry to tenacity (retry was not working and project appears stale)

This also supports filter clean / dirty and only returns zones that are enabled on the controller rather than including the zones that are disabled aswell

Copy link
Owner

@fredrike fredrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes..

Please make sure that all pre-commit tasks runs successfully.

You are right this looks like it qualifies a minor version-bump but version bumping is made during release build (make release) which will eventually be a release pipeline within github.

.bumpversion.cfg Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@fredrike
Copy link
Owner

  • managing the session entirely within init (and not within update_status)
  • removing the async with for client_session in update_status as this was closing the home assistant entity

Does this fix #3 too?

@kingy444
Copy link
Collaborator Author

I think that may have been sorted with the move to DaikinFactory class instead of the Appliance.factory method linked in the issue description

I'm definitely not seeing the same long boot times in my dev environment so I'm hopeful it would

@kingy444
Copy link
Collaborator Author

I have fixed most the pre-commit issues - but i think the pylint is failing due to this pre-commit 5973258

@kingy444 kingy444 requested a review from fredrike May 24, 2024 05:22
@fredrike
Copy link
Owner

fredrike commented May 24, 2024

The details is outlined here: https://results.[pre-commit.ci](https://results.pre-commit.ci/run/github/757419802/1716528114.uHUD88kaR5eVG68JIn2aiA)/run/github/757419802/1716528114.uHUD88kaR5eVG68JIn2aiA

There is something with pylint and netifaces, I can take a look at that.

Edit: You need to rebase with latest version on github main. (git fetch --all & git rebase upstream/main) to get pylint v3.2.2.

Fix pylint issues in pre-commit
pydaikin/discovery.py Outdated Show resolved Hide resolved
pydaikin/discovery.py Outdated Show resolved Hide resolved
@fredrike fredrike merged commit c10ab11 into fredrike:master May 24, 2024
3 checks passed
@fredrike
Copy link
Owner

Thanks a lot @kingy444 !

New version published to https://pypi.org/project/pydaikin/2.12.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants