Skip to content

Commit

Permalink
Add messaging on why query params are required
Browse files Browse the repository at this point in the history
  • Loading branch information
kingy444 committed Jul 3, 2024
1 parent 70f1d1c commit b619529
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pydaikin/daikin_airbase.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ async def set_zone(self, zone_id, key, value):
params.update({"lztemp_c": self.values["lztemp_c"]})
params.update({"lztemp_h": self.values["lztemp_h"]})

# Zone Name requires %20 encoding which is not handled well within yarl resulting
# in '%20' being encoded again to '%2520'
# For detailed info before changing the below refer to: https://github.com/fredrike/pydaikin/pull/11

# # Convert params dictionary to query string format
params_str = "&".join(f"{k}={v}" for k, v in params.items())
path = f"{path}?{params_str}" # Append params as query string to path
Expand Down

0 comments on commit b619529

Please sign in to comment.