Adding inspect_request handling #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan to borrow code from SWANK (public domain) to inspect functions and variables. This should be able to replace the SLIME feature which shows the current function argument list.
Typing Shift-Tab brings up a tooltip containing the output of DESCRIBE. To mimic the behaviour of SLIME, the function at the start of the form is described, not the symbol at the cursor.
* If no function symbol found, searches surrounding form to handle macros and let forms
* Copied public domain code from swank into src/completions.lisp into new package cl-jupyter-swank * Added a handler for complete_request message types. Currently just prints the message fields.
Finds the symbol before the cursor position using simple backward search. Will get confused by symbols with spaces in the name, but hopefully rare. Tooltip contains matching symbols sorted by length, shortest first.
|
Sorry for the delay, I have to find some spare time to try the completions before merging... This will happen soon. |
|
It looks like we have some competing implementations for Shift-Tab completion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for comments and suggestions, not yet ready for merging. I'm fairly new to Common Lisp, so feedback on ways to improve this welcome.
Typing Shift-Tab with the cursor inside a form should pop up a tooltip containing the output of DESCRIBE on the function. The aim is to mimic a feature of SLIME which I find very useful: displaying the function arguments, highlighting where the cursor is in the argument list. For example if the cursor is at the '|'
(+ 1 2 val| ) => output of (describe '+) not (describe 'val)
Getting the argument list for a given function seems to be implementation specific, but SWANK must have the code to do it.