[meteoalerte] Small code enhancements (openhab#10993)

Signed-off-by: clinique <[email protected]>
frederictobiasc · Oct 26, 2021 · 0c01e1c · 0c01e1c
1 parent b1ee118
commit 0c01e1c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 51 deletions.
diff --git a/...e/src/main/java/org/openhab/binding/meteoalerte/internal/MeteoAlerteBindingConstants.java b/...e/src/main/java/org/openhab/binding/meteoalerte/internal/MeteoAlerteBindingConstants.java
@@ -24,10 +24,8 @@
 @NonNullByDefault
 public class MeteoAlerteBindingConstants {
 
-    public static final String BINDING_ID = "meteoalerte";
-
     // List of all Thing Type UIDs
-    public static final ThingTypeUID THING_TYPE_METEO_ALERT = new ThingTypeUID(BINDING_ID, "department");
+    public static final ThingTypeUID THING_TYPE_METEO_ALERT = new ThingTypeUID("meteoalerte", "department");
 
     // List of all Channel id's
     public static final String WAVE = "vague-submersion";

diff --git a/...te/src/main/java/org/openhab/binding/meteoalerte/internal/handler/MeteoAlerteHandler.java b/...te/src/main/java/org/openhab/binding/meteoalerte/internal/handler/MeteoAlerteHandler.java
@@ -19,7 +19,6 @@
 import java.net.MalformedURLException;
 import java.nio.charset.StandardCharsets;
 import java.time.ZonedDateTime;
-import java.util.AbstractMap;
 import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.ScheduledFuture;
@@ -62,15 +61,15 @@ public class MeteoAlerteHandler extends BaseThingHandler {
             + "facet=etat_grand_froid&facet=etat_avalanches&refine.nom_dept=%s";
     private static final int TIMEOUT_MS = 30000;
     private static final String UNKNOWN_COLOR = "b3b3b3";
-    private static final Map<AlertLevel, String> ALERT_COLORS = Map.ofEntries(
-            new AbstractMap.SimpleEntry<AlertLevel, String>(AlertLevel.GREEN, "00ff00"),
-            new AbstractMap.SimpleEntry<AlertLevel, String>(AlertLevel.YELLOW, "ffff00"),
-            new AbstractMap.SimpleEntry<AlertLevel, String>(AlertLevel.ORANGE, "ff6600"),
-            new AbstractMap.SimpleEntry<AlertLevel, String>(AlertLevel.RED, "ff0000"),
-            new AbstractMap.SimpleEntry<AlertLevel, String>(AlertLevel.UNKNOWN, UNKNOWN_COLOR));
+    private static final Map<AlertLevel, String> ALERT_COLORS = Map.ofEntries(Map.entry(AlertLevel.GREEN, "00ff00"),
+            Map.entry(AlertLevel.YELLOW, "ffff00"), Map.entry(AlertLevel.ORANGE, "ff6600"),
+            Map.entry(AlertLevel.RED, "ff0000"), Map.entry(AlertLevel.UNKNOWN, UNKNOWN_COLOR));
+
+    private static final Map<AlertLevel, State> ALERT_LEVELS = Map.ofEntries(
+            Map.entry(AlertLevel.GREEN, DecimalType.ZERO), Map.entry(AlertLevel.YELLOW, new DecimalType(1)),
+            Map.entry(AlertLevel.ORANGE, new DecimalType(2)), Map.entry(AlertLevel.RED, new DecimalType(3)));
 
     private final Logger logger = LoggerFactory.getLogger(MeteoAlerteHandler.class);
-    // Time zone provider representing time zone configured in openHAB configuration
     private final Gson gson;
     private @Nullable ScheduledFuture<?> refreshJob;
     private String queryUrl = "";
@@ -96,11 +95,11 @@ public void initialize() {
     @Override
     public void dispose() {
         logger.debug("Disposing the Météo Alerte handler.");
-        ScheduledFuture<?> refreshJob = this.refreshJob;
-        if (refreshJob != null) {
-            refreshJob.cancel(true);
+        ScheduledFuture<?> localJob = refreshJob;
+        if (localJob != null) {
+            localJob.cancel(true);
         }
-        this.refreshJob = null;
+        refreshJob = null;
     }
 
     @Override
@@ -117,8 +116,7 @@ private void updateAndPublish() {
             }
             String response = HttpUtil.executeUrl("GET", queryUrl, TIMEOUT_MS);
             if (response == null) {
-                updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "empty response");
-                return;
+                throw new IOException("Empty response");
             }
             updateStatus(ThingStatus.ONLINE);
             ApiResponse apiResponse = gson.fromJson(response, ApiResponse.class);
@@ -153,7 +151,7 @@ private void updateChannels(ApiResponse apiResponse) {
         }));
     }
 
-    public byte @Nullable [] getResource(String iconPath) {
+    private byte @Nullable [] getResource(String iconPath) {
         ClassLoader classLoader = MeteoAlerteHandler.class.getClassLoader();
         if (classLoader != null) {
             try (InputStream stream = classLoader.getResourceAsStream(iconPath)) {
@@ -165,10 +163,10 @@ private void updateChannels(ApiResponse apiResponse) {
         return null;
     }
 
-    public void updateAlert(String channelId, AlertLevel value) {
+    private void updateAlert(String channelId, AlertLevel value) {
         String channelIcon = channelId + "-icon";
         if (isLinked(channelId)) {
-            updateState(channelId, getAlertLevel(value));
+            updateState(channelId, ALERT_LEVELS.getOrDefault(value, UnDefType.UNDEF));
         }
         if (isLinked(channelIcon)) {
             State result = UnDefType.UNDEF;
@@ -182,24 +180,9 @@ public void updateAlert(String channelId, AlertLevel value) {
         }
     }
 
-    public void updateDate(String channelId, ZonedDateTime zonedDateTime) {
+    private void updateDate(String channelId, ZonedDateTime zonedDateTime) {
         if (isLinked(channelId)) {
             updateState(channelId, new DateTimeType(zonedDateTime));
         }
     }
-
-    public State getAlertLevel(AlertLevel alert) {
-        switch (alert) {
-            case GREEN:
-                return DecimalType.ZERO;
-            case YELLOW:
-                return new DecimalType(1);
-            case ORANGE:
-                return new DecimalType(2);
-            case RED:
-                return new DecimalType(3);
-            default:
-                return UnDefType.UNDEF;
-        }
-    }
 }
diff --git a/...oalerte/src/main/java/org/openhab/binding/meteoalerte/internal/json/ResponseFieldDTO.java b/...oalerte/src/main/java/org/openhab/binding/meteoalerte/internal/json/ResponseFieldDTO.java
@@ -86,11 +86,7 @@ public String getNomReg() {
     }
 
     public Optional<ZonedDateTime> getDatePrevue() {
-        ZonedDateTime datePrevue = this.datePrevue;
-        if (datePrevue != null) {
-            return Optional.of(datePrevue);
-        }
-        return Optional.empty();
+        return Optional.ofNullable(datePrevue);
     }
 
     public String getTypePrev() {
@@ -126,11 +122,7 @@ public AlertLevel getVent() {
     }
 
     public Optional<ZonedDateTime> getDateInsert() {
-        ZonedDateTime dateInsert = this.dateInsert;
-        if (dateInsert != null) {
-            return Optional.of(dateInsert);
-        }
-        return Optional.empty();
+        return Optional.ofNullable(dateInsert);
     }
 
     public AlertLevel getInondation() {
@@ -158,10 +150,6 @@ public String getDep() {
     }
 
     public Optional<ZonedDateTime> getDateRun() {
-        ZonedDateTime dateRun = this.dateRun;
-        if (dateRun != null) {
-            return Optional.of(dateRun);
-        }
-        return Optional.empty();
+        return Optional.ofNullable(dateRun);
     }
 }