Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement semantic-release #85

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement semantic-release #85

wants to merge 4 commits into from

Conversation

pbrisbin
Copy link
Member

@pbrisbin pbrisbin commented Feb 6, 2025 •
edited
Loading

@pbrisbin pbrisbin force-pushed the rc/semantic-release branch from 036d63d to 6ddd684 Compare February 6, 2025 21:14
@pbrisbin pbrisbin changed the title rc/semantic release Update dependencies, implement semantic-release Feb 6, 2025
@pbrisbin pbrisbin force-pushed the rc/semantic-release branch from 6ddd684 to ad40830 Compare February 6, 2025 21:17
@pbrisbin pbrisbin changed the title Update dependencies, implement semantic-release Implement semantic-release Feb 6, 2025
@pbrisbin
Copy link
Member Author

pbrisbin commented Feb 6, 2025

Release created, with binary archives:

Release (candidate) published to Hackage:

@pbrisbin pbrisbin marked this pull request as ready for review February 6, 2025 21:48
@pbrisbin pbrisbin requested a review from a team as a code owner February 6, 2025 21:48
@pbrisbin pbrisbin requested review from joelmccracken and derelbenkoenig and removed request for a team and joelmccracken February 6, 2025 21:48
derelbenkoenig
derelbenkoenig approved these changes Feb 7, 2025
View reviewed changes
.github/workflows/release.yml
echo "$bin"
done >>"$GITHUB_PATH"
- uses: actions/checkout@v4
- uses: freckle/stack-action@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the stack-action here replacing the 'install stack' stuff that was removed?

Copy link
Member Author

@pbrisbin pbrisbin Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack-action does have an "install stack if needed" step, so moving to it does achieve that (among other things).

@pbrisbin
Copy link
Member Author

pbrisbin commented Feb 7, 2025 •
edited
Loading

So, I realized something that I need to figure out.

Since the approach of semantic-release is to update the version in the package.yml as part of release, it won't be updated at the point in time that we build the binaries. That means that when we use Paths_stackctl.version in the code to implement version, it will build with an out of date value.

I'm not sure how best to address this, but marking this PR as blocked until I have an idea.

@pbrisbin pbrisbin added the blocked This cannot move forward due to external factors label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derelbenkoenig derelbenkoenig derelbenkoenig approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked This cannot move forward due to external factors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrisbin @derelbenkoenig