Add withAssumedRole, deprecate assumeRole #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assumeRole` does not spawn a background thread to refresh credentials. This means that if the block goes on long enough, expired credentials errors will start happening. `withAssumedRole` addresses this. I chose to make a new function under a different name for two reasons: 1. The fixed function incurs a `MonadUnliftIO` constraint. Users could stay on the deprecated function if they're not able to quickly organize things to satisfy this constraint. 2. The naming better matches the analogous Amazonka function[^1]. [^1]: https://hackage.haskell.org/package/amazonka-2.0/docs/Amazonka-Auth-STS.html#v:fromAssumedRole
pbrisbin
commented
Sep 3, 2024
joelmccracken
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assumeRoledoes not spawn a background thread to refresh credentials.This means that if the block goes on long enough, expired credentials
errors will start happening.
withAssumedRoleaddresses this. I chose to make a new function under adifferent name for two reasons:
MonadUnliftIOconstraint. Users couldstay on the deprecated function if they're not able to quickly
organize things to satisfy this constraint.
Footnotes
https://hackage.haskell.org/package/amazonka-2.0/docs/Amazonka-Auth-STS.html#v:fromAssumedRole ↩