Respect STACKCTL_DIRECTORY in findRemovedStack #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
pbrisbin
requested review from
derek-ye
and removed request for
a team and
derek-ye
chris-martin
approved these changes
Apr 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
When inferring removed stacks, we use use the fact that a specification doesn't exist on disk to decide to remove the corresponding stack. Checking for the specification on disk was not using `STACKCTL_DIRECTORY`, so if one were set this would always report the file as missing and could result in deleting a stack we should not. Ideally, I would have added a failing test before fixing this, but this area is just not easy to get a test on at this time.
pbrisbin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inferring removed stacks, we use use the fact that a specification
doesn't exist on disk to decide to remove the corresponding stack.
Checking for the specification on disk was not using
STACKCTL_DIRECTORY, so if one were set this would always report thefile as missing and could result in deleting a stack we should not.