Move to a different release action #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
force-pushed
the
pb/release-action
branch
from
d819735 to
7c192a8
Compare
pbrisbin
changed the title
pbrisbin
commented
Oct 12, 2023
|
|
||
| - [ ] Descriptive, imperative-tense title | ||
| - [ ] Body explaining the _why_ of the change | ||
| - [ ] `breaking-change` or `enhancement` label applied if appropriate |
There was a problem hiding this comment.
The new release action uses GitHub's automatic release-notes feature and I've included a configuration for sectioning the listed PRs based on labels, hence this prompting to use them.
|
Example Release: NOTE: It didn't use the section titles from our |
The way things were before we created a (pulished) release first, then build and uploaded assets. This meant (particularly with OSX) the release existed as "latest" for a long time without assets. This causes issues for anyone that tries to install during this time, including some test suites. This new action allows you to create a Draft release, upload assets, then publish it -- meaning it won't be visible until it's ready, solving that problem. Annoyingly, we had to fork the action to do it, as the best one our there needed a fix and the maintainer is gone.
pbrisbin
force-pushed
the
pb/release-action
branch
from
f0d624e to
823d13e
Compare
joelmccracken
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way things were before we created a (pulished) release first, then
build and uploaded assets. This meant (particularly with OSX) the
release existed as "latest" for a long time without assets. This causes
issues for anyone that tries to install during this time, including some
test suites.
This new action allows you to create a Draft release, upload assets,
then publish it -- meaning it won't be visible until it's ready, solving
that problem.
Annoyingly, we had to fork the action to do it, as the best one our
there needed a fix and the maintainer is gone.