Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion actions #15

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Add completion actions #15

merged 4 commits into from
Nov 22, 2022

Conversation

pbrisbin
Copy link
Member

See https://github.com/pcapriotti/optparse-applicative/wiki/Bash-Completion#customizing-completions

Bash comes with built-in actions, including completing files or
directories. Let's use those where we can.

Some more we could do (but aren't yet):

  • capture -t and -p could complete relative paths under templates/
    and stacks/{account}/{region} respectively
  • capture -d could complete names of existing Stacks

See https://github.com/pcapriotti/optparse-applicative/wiki/Bash-Completion#customizing-completions

Bash comes with built-in actions, including completing files or
directories. Let's use those where we can.

Some more we could do (but aren't yet):

- `capture -t` and `-p` could complete relative paths under `templates/`
  and `stacks/{account}/{region}` respectively
- `capture -d` could complete names of existing Stacks
@pbrisbin pbrisbin requested a review from a team as a code owner November 22, 2022 14:05
@pbrisbin pbrisbin requested review from joelmccracken and removed request for a team November 22, 2022 14:05
@@ -48,7 +48,7 @@ jobs:
# - run: cram -v integration/tests

lint:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbrisbin pbrisbin merged commit 087dd35 into main Nov 22, 2022
@pbrisbin pbrisbin deleted the pb/completions branch November 22, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants