add role annotations #76
Conversation
src/Graphula.hs
Outdated
| @@ -191,12 +191,18 @@ data Args backend n m = Args | |||
| , gen :: IORef QCGen | |||
| } | |||
|
|
|||
| type role Args representational representational representational | |||
There was a problem hiding this comment.
This seems like a ton of overhead with no value. Can we -Wno-missing-role-annotations instead? We've done that many times for new warnings, e.g. with missing-kind-signatures, etc.
When it comes to our warnings choices and use of everything, the intent is not "seek to satisfy everything, only opting out what you must", it's more "everything + opt-out is better than opt-in" -- so there's no stigma to opting out of stuff. Would be good to document this somewhere I guess.
Unless there's some big benefit to this that I'm missing?
There was a problem hiding this comment.
Dunno, I didn't think it was much overhead and sometimes it's nice to make sure GHC agrees with what you thought a role was? I could go either way though, disabling the warning is fine.
There was a problem hiding this comment.
make sure GHC agrees with what you thought a role was
FWIW, I have exactly 0 idea what any role of anything is at any point. What you have here is greek to me 🤷
chris-martin
force-pushed
the
chris/role-annotations
branch
from
7a55e2f
to
4ffda57
Compare
package.yaml
Outdated
| - condition: impl(ghc >= 9.8) | ||
| ghc-options: | ||
| - -Wno-missing-role-annotations |
There was a problem hiding this comment.
Sorry to be a stickler, but the list of conditionals are currently well-ordered new-to-old, so can you put this first instead of last? (Or reverse the list entirely, I don't care which way it goes.)
to satisfy
-Weverythingon GHC 9.8