Remove unused type and dev dependency #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also unblocks #37 when rebasing that locally onto this change. |
stackptr
force-pushed
the
corey/remove-unused-type
branch
from
ccfb058 to
da439aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListCheckRunsResponseis defined but never used. Removing it means@octokit/plugin-rest-endpoint-methodsis no longer required as a dev dependency.Closes #36 and other Dependabot PRs for this package. These fail to build seemingly because TypeScript is unable to reconcile the package we're using (
7.1.0) and the package that@actions/githubuses (^5.13.0). TheskipLibCheckscompiler option might solve this, but compromises type-system accuracy, so it seems like a good thing to avoid. The underlying issue seems related to: octokit/plugin-rest-endpoint-methods.js#172 (comment)