test: Disable gometalinter as it fails to install

To be replaced in the near future with golangci-lint, which fully
replaces gometalinter in terms of functionality, plus adds some more.

    # gopkg.in/alecthomas/gometalinter.v1
    Error: ../../../../pkg/mod/gopkg.in/alecthomas/[email protected]/main.go:129:69: cannot use loadConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("config", "Load JSON configuration from file.").Action
    Error: ../../../../pkg/mod/gopkg.in/alecthomas/[email protected]/main.go:130:104: cannot use disableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("disable", "Disable previously enabled linters.").PlaceHolder("LINTER").Short('D').Action
    Error: ../../../../pkg/mod/gopkg.in/alecthomas/[email protected]/main.go:131:103: cannot use enableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("enable", "Enable previously disabled linters.").PlaceHolder("LINTER").Short('E').Action
    Error: ../../../../pkg/mod/gopkg.in/alecthomas/[email protected]/main.go:135:60: cannot use disableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("disable-all", "Disable all linters.").Action
    Error: ../../../../pkg/mod/gopkg.in/alecthomas/[email protected]/main.go:136:58: cannot use enableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("enable-all", "Enable all linters.").Action

Signed-off-by: Joe Groocock <[email protected]>

docker/Dockerfile.build

@@ -8,5 +8,5 @@ ENV PKG_CONFIG_PATH=/opt/rh/rh-ruby22/root/usr/lib64/pkgconfig${PKG_CONFIG_PATH:
 
 RUN yum -y install epel-release wget unzip git make which centos-release-scl gcc && sed -i "s/enabled=0/enabled=1/" /etc/yum.repos.d/epel-testing.repo && yum -y install rh-ruby22 && wget -O /opt/go1.9.1.linux-amd64.tar.gz https://storage.googleapis.com/golang/go1.9.1.linux-amd64.tar.gz && tar -C /usr/local -xzf /opt/go1.9.1.linux-amd64.tar.gz
 RUN mkdir -p $GOPATH/src/github.com/purpleidea && cd $GOPATH/src/github.com/purpleidea && git clone --recursive https://github.com/purpleidea/mgmt
-RUN go get -u gopkg.in/alecthomas/gometalinter.v1 && cd $GOPATH/src/github.com/purpleidea/mgmt && make deps && make build
+RUN cd $GOPATH/src/github.com/purpleidea/mgmt && make deps && make build
 CMD ["/bin/bash"]

misc/make-deps.sh

@@ -139,11 +139,6 @@ go get golang.org/x/lint/golint				# for `golint`-ing
 go get golang.org/x/tools/cmd/goimports		# for fmt
 go get github.com/kevinburke/go-bindata/go-bindata	# for compiling in non golang files
 go get github.com/dvyukov/go-fuzz/go-fuzz		# for fuzzing the mcl lang bits
-if in_ci; then
-	go get -u gopkg.in/alecthomas/gometalinter.v1 && \
-	mv "$(dirname $(command -v gometalinter.v1))/gometalinter.v1" "$(dirname $(command -v gometalinter.v1))/gometalinter" && \
-	gometalinter --install	# bonus
-fi
 fold_end "Install golang tools"
 
 fold_start "Install miscellaneous tools"

test.sh

@@ -66,7 +66,7 @@ if label-block "basic"; then
 	run-testsuite ./test/test-govet.sh
 	run-testsuite ./test/test-examples.sh
 	run-testsuite ./test/test-gotest.sh
-	run-testsuite ./test/test-gometalinter.sh
+	skip-testsuite ./test/test-gometalinter.sh # broken; to be replaced with golangci-lint
 	run-testsuite ./test/test-golint.sh	# test last, because this test is somewhat arbitrary
 	# FIXME: this now fails everywhere :(
 	skip-testsuite ./test/test-reproducible.sh