Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQL syntax error in Purchase Receipt query for empty filters #44636

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

navinrc
Copy link

@navinrc navinrc commented Dec 10, 2024

Added early return for empty data

BEFORE:

error:

Screenshot 2024-12-10 at 1 54 05 PM Screenshot 2024-12-10 at 1 58 10 PM

AFTER:

Screenshot 2024-12-10 at 1 58 38 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 10, 2024
@navinrc navinrc changed the title Fix: SQL syntax error in Purchase Receipt query for empty filters fix: SQL syntax error in Purchase Receipt query for empty filters Dec 10, 2024
@ruthra-kumar ruthra-kumar self-assigned this Dec 10, 2024
@ruthra-kumar ruthra-kumar self-requested a review December 10, 2024 10:33
@navinrc navinrc force-pushed the fix-sql-error-purchase-receipt-query branch from fc87ade to 3c6f40b Compare December 10, 2024 12:13
@navinrc
Copy link
Author

navinrc commented Dec 10, 2024

renamed old commit message for the commitlint check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants