Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v15 #44483

Merged
merged 63 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
e0cb5f9
feat(Dunning): separate tab "Address & Contact" (#44363)
barredterra Nov 26, 2024
c20def5
chore: resolve conflicts
barredterra Nov 26, 2024
0e1f5ff
fix: Add translation for showing mandatory fields in error msg
Abdeali099 Nov 27, 2024
70b5b08
feat: add Company Contact Person in selling transactions (backport #4…
mergify[bot] Nov 27, 2024
0fbc60a
fix: show "Send SMS" only when enabled (backport #43941) (#43970)
mergify[bot] Nov 27, 2024
c3bc724
fix: IndexError in Asset Depreciation Ledger when query result is empty
khushi8112 Nov 28, 2024
5bbef90
chore: removed print statement
khushi8112 Nov 28, 2024
173d60f
fix: typeerror on transaction.js
ruthra-kumar Nov 28, 2024
11c54d2
Merge pull request #44407 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Nov 28, 2024
8ab9fc7
fix: Data Should be Computed in Backend to Maintain Consistent Behavi…
Ninad1306 Nov 28, 2024
0084f45
Merge pull request #44410 from frappe/mergify/bp/version-15-hotfix/pr…
vorasmit Nov 28, 2024
651d7e4
Merge pull request #44402 from frappe/mergify/bp/version-15-hotfix/pr…
khushi8112 Nov 28, 2024
633be8d
fix: link cash flow rows and fix summary linking
blaggacao Jul 29, 2024
48d6fca
chore: resolve conflict
ruthra-kumar Nov 29, 2024
ae81bb3
chore: revert 'stub'
ruthra-kumar Nov 29, 2024
5b2fce2
Merge pull request #44419 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Nov 29, 2024
5f785ed
refactor: Used object to get payment request status indicator
Abdeali099 Nov 23, 2024
0d67c62
fix: Dashboard for `Payment Request`
Abdeali099 Nov 23, 2024
9c4b581
revert: remove default `Payment Request` indicator color
Abdeali099 Nov 26, 2024
4b04616
refactor: Move `PR` link filters to client side
Abdeali099 Nov 27, 2024
5999a8e
fix: Add filter for `outstanding_amount` to fetch open PRs
Abdeali099 Nov 27, 2024
1c50111
chore: resolve conflict
ruthra-kumar Nov 29, 2024
35e365c
Merge pull request #44425 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Nov 29, 2024
821f392
Merge pull request #44391 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Nov 29, 2024
e607795
fix: do not validate stock during inward (backport #44417) (#44427)
mergify[bot] Nov 29, 2024
0e39aa3
fix: SABB print for packed items (backport #44413) (#44428)
mergify[bot] Nov 29, 2024
0d41c23
fix: precision calculation causing 0.1 discrepancy (backport #44431) …
mergify[bot] Nov 29, 2024
c81b5e3
fix: source warehouse not set in required items of WO (backport #4442…
mergify[bot] Nov 29, 2024
1f97979
perf: cache product bundle items at document level (#44440)
sagarvora Nov 29, 2024
a1643ad
Merge pull request #44442 from frappe/mergify/bp/version-15-hotfix/pr…
sagarvora Nov 29, 2024
17c2734
fix: added fieldname to avoid fieldname to translate
Abdeali099 Nov 29, 2024
0199bc1
Merge pull request #44445 from frappe/mergify/bp/version-15-hotfix/pr…
sagarvora Nov 29, 2024
48059a7
perf: reduce queries during transaction save
sagarvora Nov 29, 2024
a807776
Merge pull request #44447 from frappe/mergify/bp/version-15-hotfix/pr…
sagarvora Nov 29, 2024
579d8e2
fix: number format in the message (backport #44435) (#44438)
mergify[bot] Nov 30, 2024
eb4a485
fix: Added translation for `Account` column
Abdeali099 Nov 29, 2024
fdda864
fix: Translate `Party Account` column label
Abdeali099 Dec 2, 2024
c8e2c9a
fix: handle multi currency in common party journal entry
ljain112 Nov 28, 2024
d0356f8
Merge pull request #44463 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 2, 2024
4c5570a
chore: resolve conflict
ruthra-kumar Dec 2, 2024
f5ddc9a
Merge pull request #44465 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 2, 2024
ae93f7f
fix: set correct unallocated amount in Payment Entry (#43958)
sagarvora Dec 2, 2024
c157978
chore: resolve conflicts
ruthra-kumar Dec 2, 2024
7150aff
Merge pull request #44466 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 2, 2024
85fda71
Merge pull request #44368 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
5c6d9c9
refactor(UI): Rearranging fields under new sections
ruthra-kumar Dec 2, 2024
38aa376
Merge pull request #44477 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
05795af
fix: always set sales incoming rate for internal transfers
Ninad1306 Nov 27, 2024
558d49b
test: validate buying workflow
Ninad1306 Nov 27, 2024
435280d
fix: adjusted incoming rate for zero rated item in purchase receipt
ljain112 Nov 28, 2024
be0604f
Merge pull request #44478 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
0c28726
Merge pull request #44480 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
ebdacc0
fix: calculate submitted payment entry as paid amount
Sugesh393 Nov 29, 2024
aa090be
test: add new unit test to validate paid amount in payment request
Sugesh393 Nov 29, 2024
0a9c92f
fix: incorrect Gross Margin on project (backport #44461) (#44468)
mergify[bot] Dec 3, 2024
c880476
Merge pull request #44481 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
ea57f2b
fix: remove queries
ljain112 Dec 2, 2024
f165e17
fix: correct buying amount for product bundel
ljain112 Dec 2, 2024
4a713f6
chore: fix typo
ruthra-kumar Dec 3, 2024
d5a544c
Merge pull request #44485 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
63de576
fix: move validate_total_debit_and_credit from validate to on_submit …
vishakhdesai Nov 26, 2024
16d0d42
refactor: validate debit and credit on before_submit
ruthra-kumar Dec 3, 2024
3e2bc13
Merge pull request #44491 from frappe/mergify/bp/version-15-hotfix/pr…
ruthra-kumar Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 35 additions & 16 deletions erpnext/accounts/doctype/dunning/dunning.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,6 @@
"currency",
"column_break_11",
"conversion_rate",
"address_and_contact_section",
"customer_address",
"address_display",
"contact_person",
"contact_display",
"column_break_16",
"company_address",
"company_address_display",
"contact_mobile",
"contact_email",
"section_break_6",
"dunning_type",
"column_break_8",
Expand Down Expand Up @@ -56,7 +46,21 @@
"income_account",
"column_break_48",
"cost_center",
"amended_from"
"amended_from",
"address_and_contact_tab",
"address_and_contact_section",
"customer_address",
"address_display",
"column_break_vodj",
"contact_person",
"contact_display",
"contact_mobile",
"contact_email",
"section_break_xban",
"column_break_16",
"company_address",
"company_address_display",
"column_break_lqmf"
],
"fields": [
{
Expand Down Expand Up @@ -178,10 +182,8 @@
"label": "Rate of Interest (%) Yearly"
},
{
"collapsible": 1,
"fieldname": "address_and_contact_section",
"fieldtype": "Section Break",
"label": "Address and Contact"
"fieldtype": "Section Break"
},
{
"fieldname": "address_display",
Expand Down Expand Up @@ -377,11 +379,28 @@
{
"fieldname": "column_break_48",
"fieldtype": "Column Break"
},
{
"fieldname": "address_and_contact_tab",
"fieldtype": "Tab Break",
"label": "Address & Contact"
},
{
"fieldname": "column_break_vodj",
"fieldtype": "Column Break"
},
{
"fieldname": "section_break_xban",
"fieldtype": "Section Break"
},
{
"fieldname": "column_break_lqmf",
"fieldtype": "Column Break"
}
],
"is_submittable": 1,
"links": [],
"modified": "2023-06-15 15:46:53.865712",
"modified": "2024-11-26 13:46:07.760867",
"modified_by": "Administrator",
"module": "Accounts",
"name": "Dunning",
Expand Down Expand Up @@ -435,4 +454,4 @@
"states": [],
"title_field": "customer_name",
"track_changes": 1
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def test_03_accounts_only_with_account_currency_balance(self):

pe = get_payment_entry(si.doctype, si.name)
pe.paid_amount = 95
pe.source_exchange_rate = 84.211
pe.source_exchange_rate = 84.2105
pe.received_amount = 8000
pe.references = []
pe.save().submit()
Expand Down Expand Up @@ -229,7 +229,7 @@ def test_03_accounts_only_with_account_currency_balance(self):
row = next(x for x in je.accounts if x.account == self.debtors_usd)
self.assertEqual(flt(row.credit_in_account_currency, precision), 5.0) # in USD
row = next(x for x in je.accounts if x.account != self.debtors_usd)
self.assertEqual(flt(row.debit_in_account_currency, precision), 421.06) # in INR
self.assertEqual(flt(row.debit_in_account_currency, precision), 421.05) # in INR

# total_debit and total_credit will be 0.0, as JV is posting only to account currency fields
self.assertEqual(flt(je.total_debit, precision), 0.0)
Expand Down
8 changes: 5 additions & 3 deletions erpnext/accounts/doctype/journal_entry/journal_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,6 @@ def validate(self):
self.set_amounts_in_company_currency()
self.validate_debit_credit_amount()
self.set_total_debit_credit()
# Do not validate while importing via data import
if not frappe.flags.in_import:
self.validate_total_debit_and_credit()

if not frappe.flags.is_reverse_depr_entry:
self.validate_against_jv()
Expand Down Expand Up @@ -184,6 +181,11 @@ def cancel(self):
else:
return self._cancel()

def before_submit(self):
# Do not validate while importing via data import
if not frappe.flags.in_import:
self.validate_total_debit_and_credit()

def on_submit(self):
self.validate_cheque_info()
self.check_credit_limit()
Expand Down
Loading
Loading