Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor Updates in Payment Request and Payment Entry #44302

Merged
merged 8 commits into from
Nov 29, 2024
Merged

fix: Minor Updates in Payment Request and Payment Entry #44302

merged 8 commits into from
Nov 29, 2024

Conversation

Abdeali099
Copy link
Contributor

@Abdeali099 Abdeali099 commented Nov 23, 2024 •
edited
Loading

Issue: Support Ticket - 26199

Changes

  • Fix: Dashboard to view connections
  • Refactor: Used object to get indicator color instead of if - else
  • Refactor: Move PR link filters to the client side so users can easily know on what basis PRs are filtered.
  • Fix: When fetching outstanding transactions in Payment Entry, do not fetch those Payment Requests which have an Outstanding Amount of zero for PR allocation in references.
Dashboard In Light Theme

image

Dashboard In Dark Theme

image

View Filters Changes

Before:
image_2024-11-27_15-51-15

After:
image_2024-11-27_15-50-32

View Outstanding Amount filter effect

Filter:
https://github.com/Abdeali099/erpnext/blob/214dfab2697ec13e70262cb4af92ca812a2dcb80/erpnext/accounts/doctype/payment_entry/payment_entry.py#L2974

Without Filter:

Without_OA_Zero

With Filter:

With_OA_Zero

Note

Backport to V-15 and V-14

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 23, 2024
@Abdeali099 Abdeali099 changed the title refactor: Update Payment Request view logic fix: Minor Updates in Payment Request and Payment Entry Nov 27, 2024
@ruthra-kumar ruthra-kumar self-assigned this Nov 29, 2024
@ruthra-kumar ruthra-kumar merged commit 76bd101 into frappe:develop Nov 29, 2024
26 checks passed
This was referenced Nov 29, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Nov 29, 2024
@ruthra-kumar
Merge pull request #44425 from frappe/mergify/bp/version-15-hotfix/pr…
35e365c 
…-44302

fix: Minor Updates in `Payment Request` and `Payment Entry`  (backport #44302)
ruthra-kumar added a commit that referenced this pull request Nov 29, 2024
@ruthra-kumar
Merge pull request #44424 from frappe/mergify/bp/version-14-hotfix/pr…
da5b57e 
…-44302

fix: Minor Updates in `Payment Request` and `Payment Entry`  (backport #44302)
@Abdeali099 Abdeali099 deleted the refactor-payment-request branch December 2, 2024 05:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdeali099 @ruthra-kumar