fix(Payment Entry): don't check empty references #38750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual partial backport of frappe#36649
barredterra
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
The failing unit test seems to be unrelated |
|
LGTM |
ruthra-kumar
approved these changes
Dec 21, 2023
|
🎉 This PR is included in version 13.55.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual partial backport of #36649
Motivation: when creating a Payment Entry without references, we get a warning from
get_outstanding_reference_documentsbecause it didn't find any outstanding references. This makes no sense in this case and confuses the users. The guarding if-statement prevents this in v14+, hence backporting this part.Yes, this could be done prettier, with a smaller diff, but I sticked to the original implementation for consistency. Any refactors should target the develop branch and get backported from there.