-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handling of exchange rate journals in AR/AP #38004
Merged
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:ar_report_refactor_in_handling_gain_loss
Nov 10, 2023
Merged
fix: handling of exchange rate journals in AR/AP #38004
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:ar_report_refactor_in_handling_gain_loss
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #38004 +/- ##
========================================
Coverage 67.39% 67.39%
========================================
Files 757 757
Lines 60371 60379 +8
========================================
+ Hits 40686 40693 +7
- Misses 19685 19686 +1
|
ruthra-kumar
force-pushed
the
ar_report_refactor_in_handling_gain_loss
branch
2 times, most recently
from
November 10, 2023 04:30
8c0a4f5
to
c4b8201
Compare
ruthra-kumar
changed the title
refactor: handling of exchange rate journals in AR/AP
fix: handling of exchange rate journals in AR/AP
Nov 10, 2023
ruthra-kumar
force-pushed
the
ar_report_refactor_in_handling_gain_loss
branch
from
November 10, 2023 05:02
c4b8201
to
1d8fcd6
Compare
ruthra-kumar
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
labels
Nov 10, 2023
This was referenced Nov 10, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Nov 10, 2023
…-38004 fix: handling of exchange rate journals in AR/AP (backport #38004)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 10, 2023
…-38004 fix: handling of exchange rate journals in AR/AP (backport #38004)
@mergify backport version-14 |
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Nov 10, 2023
fix: handling of exchange rate journals in AR/AP (backport #38004)
This was referenced Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New checkbox to tweak
outstanding
andoutstanding_in_account_currency
handling logic to better accomodate Exchange Rate Revaluation journals.