refactor: ignore disabled account while selecting Income Accounts

[ruthra-kumar]

Filter disabled accounts while selecting Income Account.

[deepeshgarg007]

While you are doing this, maybe remove usage of cur_frm and do the standard way using frm triggers?

[bosue]

Interesting.

While the right one, Expense Account, automatically discards disabled accounts, the left one doesn‘t. Would have to investigate why, but adding it manually should normally be superfluous.

Also, the right one at least filters for Profit and Loss accounts.

Neither one is configured to properly filter for only the relevant Account Type – Income Account and Expense Account, respectively.
One could say esisting sites may not have their accounts properly categorized, okay, so let‘s not backport this addition. But in develop, the proper filters should be set and enforced.

[ruthra-kumar]

@bosue
Framework implicitly adds disabled or enabled filter conditions based on doctype meta, granted the search has no custom query in it. https://github.com/frappe/frappe/blob/6ad2e762d325f0b62c2cf9dc4659497a0df9b3dd/frappe/desk/search.py#L154-L157

In this case, Income Account uses a custom query but Expense Account doesn't. This explains the different behaviour on the two link fields.

[bosue]

@ruthra-kumar: Thanks and sorry, I was a bit tired…
If we don‘t need a custom query here, and I don’t think we do, we should avoid it.
We should also filter for Profit and Loss accounts, at the least.
Filtering for Account Type may be a followup not being backported.

[codecov]

Codecov Report

Merging #37860 (6e3e094) into develop (10b9570) will decrease coverage by 0.02%.
Report is 33 commits behind head on develop.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           develop   #37860      +/-   ##
===========================================
- Coverage    67.41%   67.40%   -0.02%     
===========================================
  Files          757      757              
  Lines        60327    60337      +10     
===========================================
  Hits         40668    40668              
- Misses       19659    19669      +10     

Files	Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py	83.91% <100.00%> (ø)
.../report/accounts_receivable/accounts_receivable.py	89.96% <100.00%> (ø)
erpnext/accounts/utils.py	73.16% <100.00%> (ø)
erpnext/controllers/queries.py	57.56% <100.00%> (+0.12%)	⬆️
...ext/manufacturing/doctype/work_order/work_order.py	80.66% <100.00%> (ø)
...cturing/doctype/production_plan/production_plan.py	84.40% <94.44%> (ø)
erpnext/stock/doctype/bin/bin.py	96.20% <91.66%> (ø)
erpnext/assets/doctype/asset/depreciation.py	83.68% <50.00%> (ø)
erpnext/controllers/buying_controller.py	83.94% <20.00%> (ø)
...ent/doctype/quality_procedure/quality_procedure.py	79.71% <80.64%> (ø)

... and 10 files with indirect coverage changes

[ruthra-kumar]

@ruthra-kumar: Thanks and sorry, I was a bit tired… If we don‘t need a custom query here, and I don’t think we do, we should avoid it. We should also filter for Profit and Loss accounts, at the least. Filtering for Account Type may be a followup not being backported.

Can't avoid Custom query in this case. Check: https://github.com/frappe/erpnext/blob/9a171db97f67f88fad1589016afb4e808571d04c/erpnext/controllers/queries.py#L603C23-L605

[ruthra-kumar]

@mergify backport version-14

[mergify]

backport version-14

✅ Backports have been created

• #38021 refactor: ignore disabled account while selecting Income Accounts (backport #37860) has been created for branch version-14