Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-select customer group in AR Report #37716

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

vishdha
Copy link
Contributor

@vishdha vishdha commented Oct 27, 2023

Feat: Allow User to select multiple customer group to generate AR Report

Screenshot from 2023-10-27 11-19-56

backport to v14

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #37716 (3040203) into develop (4bbad7f) will increase coverage by 0.09%.
Report is 116 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #37716      +/-   ##
===========================================
+ Coverage    67.32%   67.42%   +0.09%     
===========================================
  Files          757      755       -2     
  Lines        60147    60303     +156     
===========================================
+ Hits         40495    40657     +162     
+ Misses       19652    19646       -6     
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 90.01% <100.00%> (-0.55%) ⬇️

... and 41 files with indirect coverage changes

@vishdha
Copy link
Contributor Author

vishdha commented Oct 30, 2023

@deepeshgarg007 is anything else needed to merge this?

@vishdha vishdha force-pushed the ar_report branch 2 times, most recently from 3b5e100 to d57107c Compare November 6, 2023 07:07
@vishdha
Copy link
Contributor Author

vishdha commented Nov 6, 2023

@deepeshgarg007 is anything missing test case also added

@ruthra-kumar ruthra-kumar self-assigned this Nov 6, 2023
@ruthra-kumar ruthra-kumar merged commit 89612f2 into frappe:develop Nov 9, 2023
13 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Nov 9, 2023
ruthra-kumar added a commit that referenced this pull request Nov 9, 2023
…-37716

feat: multi-select customer group in AR Report (backport #37716)
deepeshgarg007 added a commit that referenced this pull request Nov 9, 2023
…-37716

feat: multi-select customer group in AR Report (backport #37716)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants